refactor(x/ecocredit): reduce event fields and duplication

[ryanchristo]

Description

Closes: #1035

Removes unnecessary and redundant event fields. Also applies consistent use of present tense event names.

For basket EventCreate

• Deprecating curator because we can look up the curator with the basket denom and the creator of the basket is always assigned as the curator

For basket EventPut

• Deprecating credits because core EventTransfer (previously EventReceive) is emitted providing information about the sender, receiver, and credits transferred.

• Deprecating amount because sdk coinbase is triggered providing information about the denom and amount minted and sdk transfer event provides information about sender, receiver, and coins transferred.

For basket EventTake

• Deprecating credits because core EventTransfer (previously EventReceive) is emitted providing information about the sender, receiver, and credits transferred.

• Deprecating amount because sdk burn event is emitted providing information about the denom and amount burned and sdk transfer event provides information about sender, receiver, and coins transferred.

For core EventReceive

• Renamed to EventTransfer
• Updated sender and receiver to module address
• Removed basket_denom because the sender will be the module address in this case

For update events in general

• Removed all fields except for the unique identifier used to look up the item that was updated

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #1086 (e6a5fa1) into master (4af5dbb) will decrease coverage by 0.09%.
The diff coverage is 89.23%.

@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
- Coverage   67.98%   67.89%   -0.10%     
==========================================
  Files         210      209       -1     
  Lines       20949    20929      -20     
==========================================
- Hits        14242    14209      -33     
- Misses       5387     5398      +11     
- Partials     1320     1322       +2     

Flag	Coverage Δ
experimental-codecov	67.89% <89.23%> (-0.03%)	⬇️
stable-codecov	?

Flags with carried forward coverage won't be shown. Click here to find out more.

[technicallyty]

MintBatchCredits asserts that req.Issuer == batch.Issuer. if this is the intended functionality, i think we can remove issuer from this event. otherwise if accounts that != original issuer address should be able to mint, we should open a new issue to resolve that discrepancy

[ryanchristo]

Only the original issuer should be able to mint and it looks like it is implemented correctly. Removed here and also removed in CreateBatch. Was thinking something different at the time but not needed. 👍 67b3232

[ryanchristo]

v0.7 required for go 1.18.

[technicallyty]

lgtm, just one sneaky json file leftover 😄

[aleem1314]

lgtm