Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary fields from events #1035

Closed
4 tasks
Tracked by #818
ryanchristo opened this issue Apr 19, 2022 · 1 comment · Fixed by #1086
Closed
4 tasks
Tracked by #818

Remove unnecessary fields from events #1035

ryanchristo opened this issue Apr 19, 2022 · 1 comment · Fixed by #1086
Assignees
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Apr 19, 2022

Summary

Events should return only the necessary information that can then be used to lookup relevant details (e.g. creating a project should emit an event that includes the project id so that the project information can be looked up using the id rather than the event including all the project information).

Problem Definition

Events are not intended to be used in place of queries and should only include the necessary information to look up more information with queries.

Proposal

Remove unnecessary fields from events.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ryanchristo ryanchristo added Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature labels Apr 19, 2022
@aaronc
Copy link
Member

aaronc commented Apr 19, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants