-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/ecocredit): add bridge receive event and update bridge event #1224
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1224 +/- ##
=======================================
Coverage 70.94% 70.95%
=======================================
Files 240 240
Lines 24324 24349 +25
=======================================
+ Hits 17257 17276 +19
- Misses 5655 5658 +3
- Partials 1412 1415 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Only question is if we should also add amount to BridgeReceive. I'm not sure that EventBridgeReceive
conveys anything meaningful with just project_id and batch_denom as the only fields.
|
||
// EventBridgeReceive is emitted when credits are bridged from another chain. | ||
message EventBridgeReceive { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the use case for this event? I'm wondering if we should also add amount
here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amount
is redundant with EventMint
, which will be emitted from Msg/CreateBatch
or Msg/MintBatchCredits
.
In general, we are taking a lean approach to event fields based on how events are written in the sdk. EventBridge
is a special case because we want to make all necessary information easily accessible to the bridge service.
We would ideally include an event specific to each message so that we can track the execution of each message and the two fields here (project id and batch denom) seem to be the most relevant to Msg/BridgeReceive
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anything, we could probably remove project id but it still seems relevant.
Description
Ref: #1193 / Ref: #1206
This pull request adds
EventBridgeReceive
and updatesEventBridge
to includeamount
. Additional changes included after runningmake proto-format
andmake tidy
.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change