Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(x/ecocredit): update buf schema links #1077

Merged
merged 5 commits into from
May 9, 2022

Conversation

ryanchristo
Copy link
Member

Description

Update buf schema links in the ecocredit module fixing recently changed rpc endpoints and adding and removing links based on the latest changes.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the documentation writing guidelines
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct docs: prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR only changes documentation
  • reviewed content for consistency
  • reviewed content for thoroughness
  • reviewed content for spelling and grammar
  • tested instructions (if applicable)

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1077 (7c8c9da) into master (5111e3c) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1077      +/-   ##
==========================================
- Coverage   68.03%   68.02%   -0.01%     
==========================================
  Files         210      210              
  Lines       20956    20956              
==========================================
- Hits        14258    14256       -2     
- Misses       5380     5381       +1     
- Partials     1318     1319       +1     
Flag Coverage Δ
experimental-codecov 67.92% <ø> (-0.03%) ⬇️
stable-codecov 61.79% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo changed the title docs(x/ecocoredit): update buf schema links docs(x/ecocredit): update buf schema links May 4, 2022
@ryanchristo
Copy link
Member Author

Updates will need to be applied following #1072, #1086 and #1090 so will wait on merging but ready to review otherwise. After this pull request we should probably get in the habit of updating the links alongside updates to the proto API.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just 1 issue

x/ecocredit/spec/02_state.md Outdated Show resolved Hide resolved
@ryanchristo ryanchristo merged commit 3841ec5 into master May 9, 2022
@ryanchristo ryanchristo deleted the ryan/docs-ecocredit-links branch May 9, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants