Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create file watch for type def generation #2614

Merged
merged 74 commits into from
May 31, 2021
Merged

Create file watch for type def generation #2614

merged 74 commits into from
May 31, 2021

Conversation

peterp
Copy link
Contributor

@peterp peterp commented May 23, 2021 •
edited
Loading

This is PR part two of #2486.

This adds a file watcher that determines when a particular type definition should be generated.

  • This generates the graphql.schema to the filesystem
  • This generates al the type definitions
  • type definition generation is removed from babel
  • internal now houses logic for find files and determining if they are a type of file.
  • a file watcher is added that discretely generates the correct files when conditions are met
  • the filter watcher is booted in dev mode.
  • yarn rw g types will generate the auxiliary files.

peterp added 30 commits May 11, 2021 14:25
@peterp
Add babel deps for parsing ast trees.
9859071
@peterp
Add code to abstract ast parsing.
59d8618
@peterp
Find all the cells in a project.
4cc37ca
@peterp
Add function to fetch all the cell files.
f56b078
@peterp
Fix TS warning.
b007329
@peterp
Find all directory named imports in a project.
c722e19
@peterp
Fix tests for Windows.
51cc986
@peterp
Create mirror directory in getPaths.
4123375
@peterp
Partially convert fixture to TypeScript.
0d3b469
@peterp
Generate mirror types for Cells.
c6dacb8
@peterp
Improve conditional checks for magic-modules.
6136b5a
@peterp
Clean up comments.
10b4f2c
@peterp
Convert fixture api side to TypeScript.
d3c61cc
@peterp
Generate directory named module mirror files.
115ee8f
@peterp
Remove whitespace in generated type.
d611602
@peterp
Merge remote-tracking branch 'origin/main' into pp-create-ts-mirror
514d636
@peterp
Remove "devtools" concept. Internal is always build time.
3e13137
@peterp
Bump lock file.
71d9598
@peterp
Fix test.
6a04d5b
@peterp
Improve performance by removing import-time computation.
2f226a6
@peterp
Fix lint errors.
c1b859c
@peterp
Export fn to generate types.
860b040
@peterp
Add helpful alias for testing the CLI.
ab18d44
@peterp
Add command to generate types.
38d3451
@peterp
Rename mirror types to generate types.
618d84b
@peterp
Generate global types for imported pages.
9272814
@peterp
Replace glob with fast-glob.
a8dd4f8
@peterp
Remove pre-build-tasks and replace with generate-types.
1772964
@peterp
Add jsx ast tools.
cd0566c
@peterp
Clean up generate types.
d86adec
@peterp peterp mentioned this pull request May 30, 2021
Closed
@peterp peterp marked this pull request as ready for review May 30, 2021 19:27
@peterp peterp force-pushed the pp-create-file-watcher branch 3 times, most recently from d433fc8 to f2fe73d Compare May 31, 2021 06:26
@peterp peterp force-pushed the pp-create-file-watcher branch from f2fe73d to f975446 Compare May 31, 2021 06:51
@peterp peterp merged commit dc4730b into main May 31, 2021
@thedavidprice thedavidprice added this to the next-release milestone Jun 2, 2021
dac09 added a commit to dac09/redwood that referenced this pull request Jun 2, 2021
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into fix/scenario…
8ec2318 
…s-ts

# By David Price (6) and others
# Via GitHub
* 'main' of github.com:redwoodjs/redwood:
  build(deps): bump ts-morph from 10.1.0 to 11.0.0 (redwoodjs#2656)
  build(deps): bump core-js from 3.12.1 to 3.13.1 (redwoodjs#2680)
  bump react types and eslint packages patch version (redwoodjs#2695)
  build(deps): bump esbuild from 0.12.1 to 0.12.5 (redwoodjs#2654)
  upgrade misc packages with patch (redwoodjs#2694)
  Fix lerna canary publishing; use default --canary versioning with `git describe` (redwoodjs#2693)
  Upgrade axios due to security alert. (redwoodjs#2688)
  add esbuild config to CLI build and dev (redwoodjs#2564)
  set up yarn offline cache (redwoodjs#2669)
  Create file watch for type def generation (redwoodjs#2614)
  Pin package dependencies, remove CRWA template yarn.lock, set up Yarn offline cache (redwoodjs#2637)
  Fix serve tests (redwoodjs#2668)

# Conflicts:
#	packages/cli/src/commands/generate/types/types.js
#	packages/internal/src/generate/generate-project-typedefs.js
#	packages/internal/src/generate/helpers.js
#	packages/internal/src/generate/templates/scenarios.d.ts.template
dac09 added a commit to dac09/redwood that referenced this pull request Jun 2, 2021
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into fix/jest-fil…
8c34c2c 
…ter-tests

* 'main' of github.com:redwoodjs/redwood:
  downgrade jest-watch-typeahead 0.6.3 (redwoodjs#2699)
  Exclude yarn packages cache. (redwoodjs#2697)
  build(deps): bump ts-morph from 10.1.0 to 11.0.0 (redwoodjs#2656)
  build(deps): bump core-js from 3.12.1 to 3.13.1 (redwoodjs#2680)
  bump react types and eslint packages patch version (redwoodjs#2695)
  build(deps): bump esbuild from 0.12.1 to 0.12.5 (redwoodjs#2654)
  upgrade misc packages with patch (redwoodjs#2694)
  Fix lerna canary publishing; use default --canary versioning with `git describe` (redwoodjs#2693)
  Upgrade axios due to security alert. (redwoodjs#2688)
  add esbuild config to CLI build and dev (redwoodjs#2564)
  set up yarn offline cache (redwoodjs#2669)
  Create file watch for type def generation (redwoodjs#2614)
  Pin package dependencies, remove CRWA template yarn.lock, set up Yarn offline cache (redwoodjs#2637)
  Fix serve tests (redwoodjs#2668)
  Add script to create a functional test project using the latest CRWA template (redwoodjs#2324)
  build(deps): bump @typescript-eslint/eslint-plugin from 4.24.0 to 4.25.0 (redwoodjs#2627)
  Manage history state length exploding if clicking on a link with with the current route location (redwoodjs#2616)
  [forms] Fix number validation msg (redwoodjs#2552)
@dac09 dac09 mentioned this pull request Jun 4, 2021
Closed
@jtoar jtoar mentioned this pull request Jun 28, 2021
Closed
@thedavidprice thedavidprice deleted the pp-create-file-watcher branch November 24, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@peterp @thedavidprice