-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formalize TypeScrip type definition generation #2486
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
3d1fdb7
to
b007329
Compare
f225eba
to
168919b
Compare
168919b
to
6136b5a
Compare
This was referenced May 23, 2021
Closed
Closing for #2614 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a two part PR, this is part one.
In this PR I've formalize TypeScript type definition generation by...
@redwoodjs/internal
The file finders I've created are:
findCells()
findDirectoryNamedModules()
The AST helpers I've created are:
getNamedExports(code)
: returns all the named exports in a module.hasDefaultExport(code)
: boolean that indicates if a module has a default export.The JSX helper:
getJsxElements(code, 'Router')
: This will create a simple tree of components that's easily parseable:Given the following code...
You'll receive...
The second part of this PR will add a file watching process that will trigger type definition creation when certain files are created, deleted or modified.