Manage history state length exploding if clicking on a link with with the current route location #2616
Conversation
| it('does add to the history if they are already at that location', () => { | ||
| expect(global.history.length).toEqual(2) | ||
| navigate('/test-2') | ||
| expect(global.history.length).toEqual(3) | ||
| navigate('/test-3') | ||
| expect(global.history.length).toEqual(4) | ||
| }) |
There was a problem hiding this comment.
Thoughts on this test. I was having a hard time figuring out how to clear the global history. Open to changes if necessary
There was a problem hiding this comment.
I know history is readonly in the browser, but I wonder if that's true for jest.
I don't think it's a huge problem, since I think history is reset for every test file.
There was a problem hiding this comment.
Yeah I searched around for a bit couldn't find a way. Tried something like
global.history = new History()
but typescript yells that it is an illegal constructor.
Did a bit of googling but most of the answers out there were for react-router and they were using a mock of their custom history obj.
Dunno if there is a way to reset the environment between the tests And I believe it does reset the history after every test file though
There was a problem hiding this comment.
🆒 🆒 🆒 , I actually believe I read the same, but I couldn't find it in the docs. Maybe the best thing to do is leave a comment that we believe the history is reset in each test file, but couldn't find docs for it.
| it('does add to the history if they are already at that location', () => { | ||
| expect(global.history.length).toEqual(2) | ||
| navigate('/test-2') | ||
| expect(global.history.length).toEqual(3) | ||
| navigate('/test-3') | ||
| expect(global.history.length).toEqual(4) | ||
| }) |
There was a problem hiding this comment.
I know history is readonly in the browser, but I wonder if that's true for jest.
I don't think it's a huge problem, since I think history is reset for every test file.
110d350 to
778f21a
Compare
|
@peterp I updated the tests and the navigate function to handle hash, search, and pathname. Don't love that the tests could be brittle but still unsure if there is a way to reset the history object for each test. |
|
Huge thanks @KrisCoulson 🚀 |
… the current route location (redwoodjs#2616) * redwoodjs#1584 manage history state length * handle pathname, search, and hash * remove console.log Co-authored-by: David Price <thedavid@thedavidprice.com>
…ter-tests * 'main' of github.com:redwoodjs/redwood: downgrade jest-watch-typeahead 0.6.3 (redwoodjs#2699) Exclude yarn packages cache. (redwoodjs#2697) build(deps): bump ts-morph from 10.1.0 to 11.0.0 (redwoodjs#2656) build(deps): bump core-js from 3.12.1 to 3.13.1 (redwoodjs#2680) bump react types and eslint packages patch version (redwoodjs#2695) build(deps): bump esbuild from 0.12.1 to 0.12.5 (redwoodjs#2654) upgrade misc packages with patch (redwoodjs#2694) Fix lerna canary publishing; use default --canary versioning with `git describe` (redwoodjs#2693) Upgrade axios due to security alert. (redwoodjs#2688) add esbuild config to CLI build and dev (redwoodjs#2564) set up yarn offline cache (redwoodjs#2669) Create file watch for type def generation (redwoodjs#2614) Pin package dependencies, remove CRWA template yarn.lock, set up Yarn offline cache (redwoodjs#2637) Fix serve tests (redwoodjs#2668) Add script to create a functional test project using the latest CRWA template (redwoodjs#2324) build(deps): bump @typescript-eslint/eslint-plugin from 4.24.0 to 4.25.0 (redwoodjs#2627) Manage history state length exploding if clicking on a link with with the current route location (redwoodjs#2616) [forms] Fix number validation msg (redwoodjs#2552)
Closes #1584
Relates #2567