Fix lerna canary publishing; use default --canary versioning with git describe
#2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jun 2, 2021
…s-ts # By David Price (6) and others # Via GitHub * 'main' of github.com:redwoodjs/redwood: build(deps): bump ts-morph from 10.1.0 to 11.0.0 (redwoodjs#2656) build(deps): bump core-js from 3.12.1 to 3.13.1 (redwoodjs#2680) bump react types and eslint packages patch version (redwoodjs#2695) build(deps): bump esbuild from 0.12.1 to 0.12.5 (redwoodjs#2654) upgrade misc packages with patch (redwoodjs#2694) Fix lerna canary publishing; use default --canary versioning with `git describe` (redwoodjs#2693) Upgrade axios due to security alert. (redwoodjs#2688) add esbuild config to CLI build and dev (redwoodjs#2564) set up yarn offline cache (redwoodjs#2669) Create file watch for type def generation (redwoodjs#2614) Pin package dependencies, remove CRWA template yarn.lock, set up Yarn offline cache (redwoodjs#2637) Fix serve tests (redwoodjs#2668) # Conflicts: # packages/cli/src/commands/generate/types/types.js # packages/internal/src/generate/generate-project-typedefs.js # packages/internal/src/generate/helpers.js # packages/internal/src/generate/templates/scenarios.d.ts.template
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jun 2, 2021
…ter-tests * 'main' of github.com:redwoodjs/redwood: downgrade jest-watch-typeahead 0.6.3 (redwoodjs#2699) Exclude yarn packages cache. (redwoodjs#2697) build(deps): bump ts-morph from 10.1.0 to 11.0.0 (redwoodjs#2656) build(deps): bump core-js from 3.12.1 to 3.13.1 (redwoodjs#2680) bump react types and eslint packages patch version (redwoodjs#2695) build(deps): bump esbuild from 0.12.1 to 0.12.5 (redwoodjs#2654) upgrade misc packages with patch (redwoodjs#2694) Fix lerna canary publishing; use default --canary versioning with `git describe` (redwoodjs#2693) Upgrade axios due to security alert. (redwoodjs#2688) add esbuild config to CLI build and dev (redwoodjs#2564) set up yarn offline cache (redwoodjs#2669) Create file watch for type def generation (redwoodjs#2614) Pin package dependencies, remove CRWA template yarn.lock, set up Yarn offline cache (redwoodjs#2637) Fix serve tests (redwoodjs#2668) Add script to create a functional test project using the latest CRWA template (redwoodjs#2324) build(deps): bump @typescript-eslint/eslint-plugin from 4.24.0 to 4.25.0 (redwoodjs#2627) Manage history state length exploding if clicking on a link with with the current route location (redwoodjs#2616) [forms] Fix number validation msg (redwoodjs#2552)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2691
I suspect the root cause is that we have not been using annotated git tags. Lerna uses
git describebehind the scenes to determine the--canaryversion. However,git describeonly return the most recent annotated tag, which in our case was v0.23. I believe Peter originally tried to resolve this usinggit fetch --depth=1 origin +refs/tags/*:refs/tags/*in the GH workflow.Here are the steps I've taken:
git tag -am v0.32.3 "v0.32.3"git fetch ...git tag -am ...(annotated tag)If the CI passes, I'll merge and check if canary is working successfully.