Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "[Prototype] [Core] Make expensive subpackage imports dynamic. (#27658)"" #30219

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Revert "Revert "[Prototype] [Core] Make expensive subpackage imports dynamic. (#27658)"" #30219

merged 2 commits into from
Nov 16, 2022

Conversation

rickyyx
Copy link
Member

@rickyyx rickyyx commented Nov 11, 2022 •
edited
Loading

Reverts #29659

Closes #29557

@rickyyx rickyyx marked this pull request as ready for review November 14, 2022 17:56
@rickyyx
Copy link
Member Author

rickyyx commented Nov 14, 2022

@clarkzinzow Do you know which gcs tests this original PR is causing the regression?

@rickyyx rickyyx mentioned this pull request Nov 14, 2022
Closed
@rickyyx
Copy link
Member Author

rickyyx commented Nov 14, 2022

Somehow there were 2 builds associated with PR: https://buildkite.com/ray-project/oss-ci-build-pr/builds/4997#_ seems to be the more useful one.
Rather than this branch build https://buildkite.com/ray-project/oss-ci-build-branch/builds/1035

@rickyyx
Copy link
Member Author

rickyyx commented Nov 14, 2022

Test failures look unreleated to me.

tests:test_gcs_fault_tolerance PASS: https://buildkite.com/ray-project/oss-ci-build-pr/builds/4997#0184688c-4c0e-41cf-be6b-3e798bc3d660
tests:test_gcs_pubsub PASS: https://buildkite.com/ray-project/oss-ci-build-pr/builds/4997#0184688c-4c0e-41cf-be6b-3e798bc3d660

@rkooo567
Copy link
Contributor

cc @scv119

@scv119
Copy link
Contributor

scv119 commented Nov 15, 2022

hmm there are a bunch of tests failed to run?

@rickyyx
Copy link
Member Author

rickyyx commented Nov 15, 2022

hmm there are a bunch of tests failed to run?

This should be right CI: https://buildkite.com/ray-project/oss-ci-build-pr/builds/4997#

@jiaodong jiaodong mentioned this pull request Nov 16, 2022
Merged
7 tasks
@scv119 scv119 requested a review from clarkzinzow November 16, 2022 23:47
@scv119 scv119 merged commit 3fbd9a6 into master Nov 16, 2022
@scv119 scv119 deleted the revert-29659-core/revert/dynamic-subpackage-import branch November 16, 2022 23:48
@architkulkarni architkulkarni mentioned this pull request Nov 18, 2022
Merged
7 tasks
architkulkarni added a commit that referenced this pull request Nov 19, 2022
@architkulkarni
[CI] [runtime env] Skip flaky test_no_spurious_worker_startup on wi…
eb9463d 
…ndows (#30482)

This test recently became much flakier:

It's not clear what caused it. The seemingly most relevant PR around that time is #30219 but it's not obvious how it connects to the failing test.

This PR skips the test on Windows to fix CI, but we should identify and fix the cause of flakiness.
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@rickyyx @WeichenXu123
Revert "Revert "[Prototype] [Core] Make expensive subpackage imports …
30c744b 
…dynamic. (ray-project#27658)" (ray-project#29659)" (ray-project#30219)

This reverts commit b0bd270.

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@architkulkarni @WeichenXu123
[CI] [runtime env] Skip flaky test_no_spurious_worker_startup on wi…
28781b0 
…ndows (ray-project#30482)

This test recently became much flakier:

It's not clear what caused it. The seemingly most relevant PR around that time is ray-project#30219 but it's not obvious how it connects to the failing test.

This PR skips the test on Windows to fix CI, but we should identify and fix the cause of flakiness.

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@andylizf andylizf mentioned this pull request Feb 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scv119 scv119 scv119 approved these changes

@clarkzinzow clarkzinzow Awaiting requested review from clarkzinzow

Assignees

@scv119 scv119

@clarkzinzow clarkzinzow

@rkooo567 rkooo567

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Eagerly importing non-core subpackages slows down Python worker startup
4 participants
@rickyyx @rkooo567 @scv119 @clarkzinzow