Make pandas import lazy in data_batch_conversion #30352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaodong
commented
Nov 16, 2022
clarkzinzow
requested changes
Nov 16, 2022
clarkzinzow
approved these changes
Nov 16, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…30352) In my previous PR I defined a BlockFormat enum in data_batch_conversion and imported from dataset. But since dataset deps lives on critical path of ray.init(), it leads to test_dashboard failures without pandas installed. This PR makes it lazy and throw exception on all critical functions that requires pandas beyond typehint. Verified by manually uninstalling pandas, run pytest test_dashboard.py to ensure it failed, apply this PR and ensure it works as expected. Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In my previous PR I defined a
BlockFormatenum in data_batch_conversion and imported from dataset. But since dataset deps lives on critical path of ray.init(), it leads to test_dashboard failures without pandas installed. This PR makes it lazy and throw exception on all critical functions that requires pandas beyond typehint.Verified by manually uninstalling pandas, run
pytest test_dashboard.pyto ensure it failed, apply this PR and ensure it works as expected.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.