[CI] [runtime env] Skip flaky test_no_spurious_worker_startup on windows
#30482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
|
Windows tests:test_ray_init unrelated (this PR just skips a test in |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ndows (ray-project#30482) This test recently became much flakier: It's not clear what caused it. The seemingly most relevant PR around that time is ray-project#30219 but it's not obvious how it connects to the failing test. This PR skips the test on Windows to fix CI, but we should identify and fix the cause of flakiness. Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This test recently became much flakier:
It's not clear what caused it. The seemingly most relevant PR around that time is #30219 but it's not obvious how it connects to the failing test.
This PR skips the test on Windows to fix CI, but we should identify and fix the cause of flakiness.
Related issue number
Mitigates #30474 but we should fix the root cause of the flakiness before closing that issue.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.