Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Prototype] [Core] Make expensive subpackage imports dynamic. (#27658)" #29659

Conversation

clarkzinzow
Copy link
Contributor

This reverts commit 241a02e, reverting PR #27658. This PR was making some GCS tests flaky (somehow).

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@clarkzinzow clarkzinzow merged commit b0bd270 into ray-project:master Oct 25, 2022
rickyyx added a commit that referenced this pull request Nov 11, 2022
scv119 pushed a commit that referenced this pull request Nov 16, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…ray-project#27658)" (ray-project#29659)

This reverts commit 241a02e, reverting PR ray-project#27658. This PR was making some GCS tests flaky (somehow).

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…dynamic. (ray-project#27658)" (ray-project#29659)" (ray-project#30219)

This reverts commit b0bd270.

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants