Removes cluster node status reporting from agent #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigkevmcd
reviewed
Feb 29, 2024
| baseTime = metav1.Now() | ||
| ctx, cancel = context.WithCancel(context.TODO()) | ||
| clusterClient.EXPECT().Patch(clusterNamespace, clusterName, types.MergePatchType, gomock.Any(), "status"). | ||
| DoAndReturn(func(namespace, name string, pt types.PatchType, data []byte, subresources ...string) (result fleet.Cluster, err error) { |
There was a problem hiding this comment.
You declare the result here but don't actually use it?
984a8ae to
0e45d69
Compare
manno
reviewed
Mar 1, 2024
| return *cluster, nil | ||
| }).AnyTimes() | ||
| Ticker(ctx, agentNamespace, clusterNamespace, clusterName, time.Second*1, nodeClient, clusterClient) | ||
| }) |
There was a problem hiding this comment.
nit: I'd always put newlines in between the blocks, but 🤷
Suggested change
| }) | |
| }) | |
There was a problem hiding this comment.
Sure, it's more readable that way. New lines added.
eb1e041 to
1a58ae8
Compare
weyfonk
reviewed
Mar 4, 2024
1a58ae8 to
d4d298e
Compare
d4d298e to
ff4ed76
Compare
Removes cluster node status reporting from agent and adds a basic unit test for the `clusterstatus Ticker` Refers to: rancher#1973 Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
ff4ed76 to
aa041a4
Compare
weyfonk
approved these changes
Mar 4, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes cluster node status reporting from agent and adds a basic unit test for the
clusterstatus TickerRefers to: #1973