Replace Fleet Cluster Nodes Ready column

[richard-cox]

• fleet.cattle.io.cluster status.agent.readyNodes and status.display.sampleNode are soon to be removed
  • These did not show fleet specific info, and info can be obtained elsewhere
  • Removes cluster node status reporting from agent fleet#2190
• These are used in the fleet cluster model's nodeInfo property, which is used to display Nodes Ready column in the fleet cluster list
• We should replace the column with something else which might be useful. Candidates (one or all)
  • readyBundles in https://fleet.rancher.io/ref-crds#clusterdisplay
  • lastSeen in https://fleet.rancher.io/ref-crds#agentstatus

[kkaempf]

@nwmac @gaktive Fleet would need this for v2.9.0 already 🥺

[gaktive]

@kkaempf ok, we'll have to assess this. I see rancher/fleet#1973 is in QA; are there any other tickets that we need to refer to?

[thehejik]

@gaktive Just letting know that QA is done, please see report rancher/fleet#1973 (comment) with details.

[sbulage]

@richard-cox This is also impacting the imported cluster in the fleet-default workspace too. Currently blocking the existing issue checking... till this fix it, any workaround there, please let us know 😄 thanks in advance.

[yonasberhe23]

I think it would be a good idea to test this manually to make sure the data loads properly and table formatting/data alignment is good. cc @izaac FYI i'm currently working on this area of fleet so we'll have e2e tests for this soon.

This code hasn't been merged yet so I'll move this back to review. once merged can you move this to 'To Test' please @aalves08?

[thehejik]

This seems to be fixed. This is how it looks currently in 2.9-e833f80f53b04b301f881f96154392c34d3b56b1-head with fleet 104.0.0+up0.10.0-rc.14:

The Bundles Ready counter seems to be valid. There is always one Bundle for fleet-agent* and another Bundle for my added GitRepo resource (which is also shown) so two in total.

[manno]

Users often create cluster groups instead of matching clusters by name, however those groups only support a label matcher.

Would it be possible to add the user’s labels as a column?

Also, I think the bundle count is for all bundles and not limited to the selected namespace. For fleet-default, it will always be actual bundles+1, because of the agent bundle in fleet-local.

As discussed, I'll open a new issue.

[nwmac]

Thanks @manno - if you could create a new issue, that would be great.

[nwmac]

@yonasberhe23 I think this can be marked done now