Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cluster node status reporting from agent #1973

Closed
manno opened this issue Nov 27, 2023 · 2 comments
Closed

Remove cluster node status reporting from agent #1973

manno opened this issue Nov 27, 2023 · 2 comments

Comments

@manno
Copy link
Member

manno commented Nov 27, 2023

The agent reports the node status of the cluster it's running on.

It lists all nodes every 15min, or by the amount configured as CheckInterval in the agents config.

Since it also updates a timestamp, the bundledeployment is changed.

The UI only displays the timestamp for the clustergroups Last seen column.

We could remove the node count and status reporting.

This is a follow-up to #1772

@manno manno added this to Fleet Nov 27, 2023
@manno manno converted this from a draft issue Nov 27, 2023
@0xavi0 0xavi0 self-assigned this Feb 27, 2024
@manno manno moved this from 📋 Backlog to 🏗 In progress in Fleet Feb 27, 2024
0xavi0 added a commit to 0xavi0/fleet that referenced this issue Feb 29, 2024
Removes cluster node status reporting from agent and adds a basic unit test for the `clusterstatus Ticker`

Refers to: rancher#1973

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0 added a commit to 0xavi0/fleet that referenced this issue Feb 29, 2024
Removes cluster node status reporting from agent and adds a basic unit test for the `clusterstatus Ticker`

Refers to: rancher#1973

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0 added a commit to 0xavi0/fleet that referenced this issue Feb 29, 2024
Removes cluster node status reporting from agent and adds a basic unit test for the `clusterstatus Ticker`

Refers to: rancher#1973

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0 added a commit to 0xavi0/fleet that referenced this issue Feb 29, 2024
Removes cluster node status reporting from agent and adds a basic unit test for the `clusterstatus Ticker`

Refers to: rancher#1973

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@0xavi0 0xavi0 moved this from 🏗 In progress to 👀 In review in Fleet Mar 1, 2024
0xavi0 added a commit to 0xavi0/fleet that referenced this issue Mar 1, 2024
Removes cluster node status reporting from agent and adds a basic unit test for the `clusterstatus Ticker`

Refers to: rancher#1973

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0 added a commit to 0xavi0/fleet that referenced this issue Mar 1, 2024
Removes cluster node status reporting from agent and adds a basic unit test for the `clusterstatus Ticker`

Refers to: rancher#1973

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0 added a commit to 0xavi0/fleet that referenced this issue Mar 4, 2024
Removes cluster node status reporting from agent and adds a basic unit test for the `clusterstatus Ticker`

Refers to: rancher#1973

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0 added a commit to 0xavi0/fleet that referenced this issue Mar 4, 2024
Removes cluster node status reporting from agent and adds a basic unit test for the `clusterstatus Ticker`

Refers to: rancher#1973

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0 added a commit to 0xavi0/fleet that referenced this issue Mar 4, 2024
Removes cluster node status reporting from agent and adds a basic unit test for the `clusterstatus Ticker`

Refers to: rancher#1973

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@0xavi0 0xavi0 moved this from 👀 In review to ✅ Done in Fleet Mar 4, 2024
@0xavi0 0xavi0 moved this from ✅ Done to Needs QA review in Fleet Mar 13, 2024
@0xavi0 0xavi0 added this to the v2.9.0 milestone Mar 13, 2024
@0xavi0
Copy link
Contributor

0xavi0 commented Mar 13, 2024

QA Template

Solution

Deletes some information provided by fleet for the clusters.
Before this change we can get the following information from clusters:

$ kubectl get clusters -A                                                                                                                                                                                                                                                                                    
NAMESPACE     NAME    BUNDLES-READY   NODES-READY   SAMPLE-NODE             LAST-SEEN              STATUS
fleet-local   local   1/1             3/3           k3d-upstream-server-0   2024-03-13T10:34:07Z   

The change removes the values reported for "NODES-READY and SAMPLE-NODE".

Testing

Just run a command to retrieve all clusters and you should not see the NODES-READY nor SAMPLE-NODE columns
Something like:

$ kubectl get clusters -A                                                                                                                                        
NAMESPACE     NAME    BUNDLES-READY   LAST-SEEN              STATUS
fleet-local   local   1/1             2024-03-13T10:49:27Z  

Additional info

@thehejik
Copy link

thehejik commented Apr 18, 2024

Test report

Works as expected. But currently waiting for rancher/dashboard implementation as Clusters are reporting 0 Nodes Ready.

image

Tested on rancher v2.9-c9be13b09329bbee60a5f6419d500198f83c44d1-head with fleet App fleet:104.0.0+up0.10.0-rc.11

$ kubectl get clusters.fleet.cattle.io -A
NAMESPACE       NAME     BUNDLES-READY   LAST-SEEN              STATUS
fleet-local     local    1/1             2024-04-18T14:11:58Z   
fleet-default   dhcp12   2/2             2024-04-18T14:16:11Z   

Also in this diff it is visible that status information are reduced in clusters resource in v2.9 versus v2.8 and fleet:103.1.3+up0.9.3-rc.3:

image

@github-project-automation github-project-automation bot moved this from Needs QA review to ✅ Done in Fleet Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants