Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Fleet Cluster Nodes Ready column #11041

Merged

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented May 16, 2024

Summary

Fixes #10542

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

  • go to fleet clusters and check that we no longer display nodes ready (replaced by bundles ready)

Areas which could experience regressions

Screenshot/Video

Before
Screenshot 2024-05-16 at 16 46 46

Aft
Screenshot 2024-05-16 at 16 41 17
er

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.9.0 milestone May 16, 2024
@aalves08 aalves08 self-assigned this May 16, 2024
@aalves08 aalves08 requested a review from rak-phillip May 16, 2024 15:50
@aalves08 aalves08 changed the title + update flee… Replace Fleet Cluster Nodes Ready column May 16, 2024
rak-phillip
rak-phillip previously approved these changes May 16, 2024
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I left a few observations while reviewing. I think these are optional and don't block merging in any way 🙂

aalves08 added 2 commits May 17, 2024 08:55
…t cluster table to display bundles ready instead of nodes ready
@aalves08 aalves08 force-pushed the 10542-replace-fleet-cluster-nodes-ready-col branch from 6a069e0 to a7ed2fd Compare May 17, 2024 08:02
@aalves08 aalves08 requested a review from rak-phillip May 17, 2024 08:06
@aalves08 aalves08 merged commit 9b811c5 into rancher:master May 27, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Fleet Cluster Nodes Ready column
2 participants