-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added aria-live='polite' #5639
Added aria-live='polite' #5639
Conversation
✅ Deploy Preview for volto canceled.
|
✅ Deploy Preview for plone-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Hrittik20 CI checks need to pass. Same for backported PR #5640. See Change log entry and Code quality |
@stevepiercy Sorry, I forgot to add change log entry |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good. Please check ESLint.
@Hrittik20 do you get notifications from GitHub of failed GitHub workflows? I get them whenever I submit a pull request that breaks them, so I assume you would too. You can click each failed workflow's "Details" link to see what might cause the failure. Anyway, there are two workflows that you need to address. I would suggest that you run tests locally to save time, effort, and frustration. See Testing and Acceptance testing. |
@stevepiercy Yes, I am working on it. I am getting few errors while linting and testing so trying to fix it now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the change log. A core maintainer needs to review the rest.
@davisagli @stevepiercy @Hrittik20 is it possible to have this also in Volto 17? |
@giuliaghisini you mean, like in #5640? 😉 |
yes! |
* main: Block search engines from indexing content on Netlify preview builds (#5725) fixed a11y Logo Issue and added Translations (#5722) Allow editor to edit metadata name during bulk or single upload (#5560) 5439 clarify defaultAddonName option and mention to the generator readme the creation of the theme add-on (#5709) Remove turbo from monorepo commands until it's really necessary (#5715) bugfix: wrong conditional proprieties on ObjectBrowser (#4190) Added aria-live='polite' (#5639) Release 18.0.0-alpha.9 Release @plone/scripts 3.3.2 fix: handle addons that have not been migrated to the new structure o… (#5704) Update Semantic UI React to version 2.1.5 (#5632) Removed unmaintained and unused razzle-plugin-bundle-analyze (#5671) 3716 - improve validation of id widget (#4686) Fixed redirect of https://tanstack.com/query/v4/docs/react/guides/ssr… (#5700) Release 18.0.0-alpha.8 Release @plone/volto 18.0.0-alpha.7 (not pushed to main) Release @plone/slate 18.0.0-alpha.6 Release @plone/registry 1.2.1 (not pushed to repo)
Issue: #5617