3716 - improve validation of id widget #4686
Conversation
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #5051 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
src/components/manage/Widgets/__snapshots__/IdWidget.test.jsx.snap
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
|
@tedw87 status? |
|
@davisagli could you please take a second look? |
|
@tedw87 sorry to have this abandoned. What's it's status? Can we resurect it? Thanks! |
@sneridagh Hello, the updates will be as follows: 1. No uppercase letters are to be used; 2. 'contributors' should not be used as a shortname. I will update the validation criteria accordingly. Thank you. |
|
@stevepiercy I've updated the Storybook by including |
There was a problem hiding this comment.
LGTM but not a regex expert here! @stevepiercy @davisagli a final look?
|
@sneridagh the Storybook preview does not work. I have no idea why: https://65b0360fb762f40008f1c5f1--volto.netlify.app/storybook I thought I had fixed that in #5599 (comment), but it appears to have been broken in this PR. If it works locally, then I'm fine with Netlify not working and find where it went sideways later. As far as the regex, it appears that it does not reject |
|
It looks like the latest regex works: https://regex101.com/r/E5gJye/3. That leaves the Storybook build failure to resolve. I forced it to rebuild with the latest commit, but it still does not load: https://deploy-preview-4686--volto.netlify.app/storybook |
I ran Storybook locally on this branch and it works fine. I tested it in the following way: after |
|
Thanks for checking @tedw87! @sneridagh let's go ahead and merge this PR, and if the Storybook does not build and deploy after I update git submodule tips on the Plone 6 documentation, we can open a new issue to deal with it there. |
|
The Storybook build is fine in production at https://6.docs.plone.org/storybook/, so something with the Volto docs preview in Netlify might need some tweaking. |
* main: Block search engines from indexing content on Netlify preview builds (#5725) fixed a11y Logo Issue and added Translations (#5722) Allow editor to edit metadata name during bulk or single upload (#5560) 5439 clarify defaultAddonName option and mention to the generator readme the creation of the theme add-on (#5709) Remove turbo from monorepo commands until it's really necessary (#5715) bugfix: wrong conditional proprieties on ObjectBrowser (#4190) Added aria-live='polite' (#5639) Release 18.0.0-alpha.9 Release @plone/scripts 3.3.2 fix: handle addons that have not been migrated to the new structure o… (#5704) Update Semantic UI React to version 2.1.5 (#5632) Removed unmaintained and unused razzle-plugin-bundle-analyze (#5671) 3716 - improve validation of id widget (#4686) Fixed redirect of https://tanstack.com/query/v4/docs/react/guides/ssr… (#5700) Release 18.0.0-alpha.8 Release @plone/volto 18.0.0-alpha.7 (not pushed to main) Release @plone/slate 18.0.0-alpha.6 Release @plone/registry 1.2.1 (not pushed to repo)
Co-authored-by: Claudia Ifrim <ifrim.claudia@gmail.com>
I modified the regex which validates the value in
IdWidgetto match all the requirements mentioned in the issue #3716