5439 clarify defaultAddonName option and mention to the generator readme the creation of the theme add-on #5709
Conversation
…voltoproject since that is what we use in documentation
✅ Deploy Preview for plone-components canceled.
|
✅ Deploy Preview for volto canceled.
|
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@stevepiercy thx, committed the suggestions, this is such an underrated feature of the pull request review process, |
|
@ichim-david This is needed in order to get people away from doing theming in the project. I cannot see any other way. It could have been executed better, could be. Open to suggestions. We have to overhaul the generator soon anyways. |
|
@ichim-david thanks for clarifying it, I think now it's great and much better. |
@sneridagh Is creating a theme in the project a bad practice? One disadvantage I can think of is not being reusable. Any others? |
|
@wesleybl it's discouraged. The project should be something expendable, so you can migrate your code from version to version just by running the generator again, place your add-on inside. Also, it allows you to test your code in isolation, using the development docker environment approach, if needed. |
* main: Block search engines from indexing content on Netlify preview builds (#5725) fixed a11y Logo Issue and added Translations (#5722) Allow editor to edit metadata name during bulk or single upload (#5560) 5439 clarify defaultAddonName option and mention to the generator readme the creation of the theme add-on (#5709) Remove turbo from monorepo commands until it's really necessary (#5715) bugfix: wrong conditional proprieties on ObjectBrowser (#4190) Added aria-live='polite' (#5639) Release 18.0.0-alpha.9 Release @plone/scripts 3.3.2 fix: handle addons that have not been migrated to the new structure o… (#5704) Update Semantic UI React to version 2.1.5 (#5632) Removed unmaintained and unused razzle-plugin-bundle-analyze (#5671) 3716 - improve validation of id widget (#4686) Fixed redirect of https://tanstack.com/query/v4/docs/react/guides/ssr… (#5700) Release 18.0.0-alpha.8 Release @plone/volto 18.0.0-alpha.7 (not pushed to main) Release @plone/slate 18.0.0-alpha.6 Release @plone/registry 1.2.1 (not pushed to repo)
Honestly, I hope this triggers a bug acknowledgment that the generator shouldn't automatically create a theme add-on whenever the generator is used to generate the volto project, however in case this is still seen as a feature and not a bug then we should document this behavior and bring it into the awareness of anyone who uses the volto generator.
Added also some extra content to the readme and modified the example project name given from my-volto-project -> myvoltoproject since this is what we use in the documentation.