Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aria-live='polite' #5639

Merged
merged 8 commits into from
Jan 29, 2024
Merged

Added aria-live='polite' #5639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2405809
Added aria-live='polite'
Hrittik20 Jan 17, 2024
3bc8130
Merge branch 'plone:main' into aria
Hrittik20 Jan 17, 2024
480ca6f
Added change log entry file
Hrittik20 Jan 17, 2024
07bdc6e
Update packages/volto/news/5617.feature
Hrittik20 Jan 17, 2024
79335c3
Merge branch 'plone:main' into aria
Hrittik20 Jan 17, 2024
3622fe8
Resolved Prettier Conflict
Hrittik20 Jan 17, 2024
0f44dcc
Merge branch 'plone:main' into aria
Hrittik20 Jan 18, 2024
eea1de1
Updated Contents.test.jsx.snap
Hrittik20 Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/volto/news/5617.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added `aria-live="polite"` in `Contents.jsx` to improve accessibility for the Contents page. @Hrittik20
6 changes: 5 additions & 1 deletion packages/volto/src/components/manage/Contents/Contents.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,7 +1191,11 @@ class Contents extends Component {
return this.props.token && this.props.objectActions?.length > 0 ? (
<>
{folderContentsAction ? (
<Container id="page-contents" className="folder-contents">
<Container
id="page-contents"
className="folder-contents"
aria-live="polite"
>
<Dimmer.Dimmable as="div" blurring dimmed={loading}>
<Dimmer active={loading} inverted>
<Loader indeterminate size="massive">
Expand Down
1 change: 1 addition & 0 deletions packages/volto/src/components/manage/Contents/__snapshots__/Contents.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

exports[`Contents renders a folder contents view component 1`] = `
<div
aria-live="polite"
className="ui container folder-contents"
id="page-contents"
>
Expand Down