Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7228: chrome.sidePanel POC 3 #7320

Closed
wants to merge 15 commits into from
Closed

#7228: chrome.sidePanel POC 3 #7320

wants to merge 15 commits into from

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Jan 11, 2024

Tasks

  • Figure out why the mods aren't loading on the first load
  • reorganize code because some context expectations aren't clear (sidebar/sidePanel/messenger/api.ts particularly doesn't really use the messenger)
  • Use activateOptions in showSidebarFromPageEditor
  • drop sequence number
    Tracked in Sidebar changes before the sidePanel migration/merge #7319
  • Maybe close sidePanel on action click
    Edit: Can't really find a way
  • Fix tests (but maybe that'll fix itself after the MV2 version is merged back in)

Sub-tasks after the sidePanel version is in a satisfactory state

  • Merge into MV2 version

Related

@fregante fregante changed the title #7228: chrome.sidePanel POC 2 #7228: chrome.sidePanel POC 3 Jan 11, 2024
@fregante
Copy link
Contributor Author

fregante commented Jan 11, 2024

Progress

Sidebar correctly loads on open

8f36505

Demo
Screen.Recording.mov

AI Copilot side panel always works

Via context menu and locally, if it's closed or already open

Demo
Screen.Recording.2.mov

Favorites links in KB Assist work

Both those that open a new tab or a new panel

Demo
Screen.Recording.3.mov

@fregante
Copy link
Contributor Author

Progress

The sidebar mod list is updated when the website is changed

The update is quite slow because the content script is loaded on document_idle

Demo
Screen.Recording.mov

@fregante
Copy link
Contributor Author

This should still be working but I won't make any changes here. You can keep using this branch to test the MV3 version and report issues.

The MV2/MV3 compatible version will be completed in another, final PR:

@twschiller
Copy link
Contributor

Closing in favor of: #7354

@twschiller twschiller closed this Jan 18, 2024
@fregante fregante deleted the F/mv3/sidePanel-3 branch January 19, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants