Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slice 1: create throw-away Side Panel POC to demonstrate communication between content script and sidebar in Side Panel #7228

Closed
twschiller opened this issue Dec 28, 2023 · 1 comment · Fixed by #7354
Assignees

Comments

@twschiller
Copy link
Contributor

twschiller commented Dec 28, 2023

Context

Discussion

  • This is a “build one to throw it away” POC — you don’t have to worry about maintaining backward compatibility. The PR won’t be merged in

Definition of Done

Implementation Sketch

  • Add permission to manifest for MV3 builds: https://developer.chrome.com/docs/extensions/reference/api/sidePanel#permissions
  • Set the default path to sidebar.html
    • https://developer.chrome.com/docs/extensions/reference/api/sidePanel#every-site
  • Change _toggleSidebar method to use the new sidePanel API:
    async function _toggleSidebar(tabId: number, tabUrl: string): Promise<void> {
@twschiller twschiller changed the title Slice 1: create throw-away Side Panel POC to demonstrate communication between content script and Side Panel Slice 1: create throw-away Side Panel POC to demonstrate communication between content script and sidebar in Side Panel Dec 28, 2023
@twschiller
Copy link
Contributor Author

@fregante assigning this POC to you because 1/ @grahamlangford is OOO this week, 2/ you have the most context on how webext-messenger might need to change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants