Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar changes before the sidePanel migration/merge #7319

Closed
1 of 3 tasks
fregante opened this issue Jan 11, 2024 · 0 comments · Fixed by #7354
Closed
1 of 3 tasks

Sidebar changes before the sidePanel migration/merge #7319

fregante opened this issue Jan 11, 2024 · 0 comments · Fixed by #7354

Comments

@fregante
Copy link
Contributor

fregante commented Jan 11, 2024

The reasoning is that the API is a bit confusing and that shimming the sidePanel version into it might make it hard to reason about. MV2 and MV3 sidePanel have different execution paths (controller in content script vs controller in background)

Also some changes are required for the MV3 version, but can be done outside that PR.

Suggested changes:

  • Use timestamps instead of renderSequenceNumber
  • Review logic in rehydrateSidebar (it does too much)
  • extract updateSidebar from showSidebar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant