Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the "Restricted page" popup into the MV3 sidebar #7364

Closed
3 of 5 tasks
fregante opened this issue Jan 18, 2024 · 1 comment · Fixed by #7354
Closed
3 of 5 tasks

Merge the "Restricted page" popup into the MV3 sidebar #7364

fregante opened this issue Jan 18, 2024 · 1 comment · Fixed by #7354
Assignees
@fregante
Labels
mv3 rfc sidebar

Comments

@fregante
Copy link
Contributor

fregante commented Jan 18, 2024 •
edited
Loading

In the sidePanel MV3 I'm setting the restrictedUrlPopup.html URL inside the side panel in some cases. This is a temporary solution and it has issues (like the loading/reloading of the sidebar unnecessarily)

Definition of done

  • The sidebar app can show the reason why it's not available
  • The sidebar app can listen to URL changes and show the reason
  • The sidebar app will reset its state when the reason is shown
  • The reason is removed when other messages like activatePanel are received

Others

  • This state/message might need some new design cc @BrandonPxBx

Related

See the current behavior:

Blocked by:

Current look

Screenshot 5
@fregante fregante mentioned this issue Jan 18, 2024
Merged
11 tasks
@fregante fregante changed the title Add the messaging from restrictedUrlPopup to the MV3 sidebar Merge the "Restricted page" popup ito the MV3 sidebar Jan 19, 2024
@fregante fregante self-assigned this Jan 21, 2024
@fregante fregante linked a pull request Jan 21, 2024 that will close this issue
#7228: Add support for sidePanel in the MV3 build #7354
Merged
11 tasks
@fregante
Copy link
Contributor Author

The skeleton is ready and instant, I'll add it to the main PR. It only needs some polishing / style:

Screen.Recording.mov

@fregante fregante changed the title Merge the "Restricted page" popup ito the MV3 sidebar Merge the "Restricted page" popup into the MV3 sidebar Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fregante fregante

Labels
mv3 rfc sidebar
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#7228: Add support for sidePanel in the MV3 build pixiebrix/pixiebrix-extension
1 participant
@fregante