-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Integrate SkyWalking-eyes to check license headers in CI and fix licenses headers #27198
Conversation
.vol/ Applications/ Library/ System/ Users/ Volumes/ bin/ cores/ dev/ opt/ private/ sbin/ usr/ .VolumeIcon.icns .file etc home tmp var
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@fgksgf thanks for submitting this PR! Nice work. CI failed seems due to too many debug logs, please take a look https://github.com/pingcap/tidb/pull/27198/checks?check_run_id=3319959872 |
|
Because new changes with invalid license headers are continuously merged into the master... |
@fgksgf let's try to schedule a fast review to avoid too much conflict and follow up. Since CI pass for now, we can start reviewing. |
@fgksgf you may try to rearrange commits to factor out all find-and-replace in one commit so that we can do a real review. |
/run-check_dev_2 |
nice work👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
How long it takes to support this feature in the upstream github action? If it doesn't hard, I think we can wait for it. |
@zz-jason make sense. I just notice that the upstream PR get merged apache/skywalking-eyes#57 |
I just merged that PR to upstream. It should be able to use here now. |
Ok, i will update it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/assign @zz-jason Could you please help on merging this pr? |
Signed-off-by: tison <wander4096@gmail.com>
/run-check_dev_2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c43a768
|
cheers! |
What problem does this PR solve?
Issue Number: close #26956
Problem Summary:
What is changed and how it works?
What's Changed:
//
and#
How it Works: it will check the license header in CI
Check List
Release note