Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: migrate test-infra to testify #27222

Merged
merged 6 commits into from
Aug 18, 2021
Merged

config: migrate test-infra to testify #27222

merged 6 commits into from
Aug 18, 2021

Conversation

unconsolable
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #27179

What's Changed:

  • Migrate from pingcap/check to testify
  • Add a test case for InitializeConfig

Release note

None

@unconsolable
config: introduce TestMain, migrate config_util_test.go
137aebf 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
config: migrate config_util_test.go, pt.1
df73d31 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
config: migrate config_util_test.go, pt.2
11966ce 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 14, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 14, 2021
@unconsolable
Copy link
Contributor Author

/cc @tisonkun
PTAL

@ti-chi-bot ti-chi-bot requested a review from tisonkun August 14, 2021 09:25
@unconsolable
Copy link
Contributor Author

unconsolable commented Aug 16, 2021 •
edited
Loading

/uncc @tisonkun
/cc @morgo @xhebox
PTAL.

@ti-chi-bot ti-chi-bot requested review from morgo and xhebox and removed request for tisonkun August 16, 2021 10:48
tisonkun
tisonkun reviewed Aug 16, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @unconsolable ! Comments inline.

@unconsolable
config: update license header, remove redundant test
3f87bdc 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 18, 2021
@tisonkun
Copy link
Contributor

@xhebox @morgo could you help on merging this PR?

@morgo
Copy link
Contributor

morgo commented Aug 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3f87bdc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 18, 2021
@ti-chi-bot
Copy link
Member

@unconsolable: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@unconsolable
Copy link
Contributor Author

/run-build

@ti-chi-bot ti-chi-bot merged commit d2dcf29 into pingcap:master Aug 18, 2021
@unconsolable unconsolable deleted the issue-27179 branch August 18, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun left review comments

@morgo morgo morgo approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
component/config release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for config pkg
5 participants
@unconsolable @ti-chi-bot @tisonkun @morgo @xhebox