-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: license checker #2263
ADD: license checker #2263
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@tisonkun Hello, sorry to disrupt you, would you please help me find out why this license checker always fail |
@xuanyu66 because files you checked miss the license header. You can check from the error logs to find files doesn't meet the requirement. https://github.com/pingcap/tispark/runs/5509671375?check_suite_focus=true |
The license header is incorrect. |
Check pingcap/tidb#27198 for the reason. The license header is incorrect and copyed everywhere. You can do a global find and replace to fix it. |
@tisonkun thank you. It doesn't occur to me that license header is in correct |
/cherrypick release-2.5 |
@xuanyu66: once the present PR merges, I will cherry-pick it on top of release-2.5 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/cherrypick release-2.4 |
@xuanyu66: once the present PR merges, I will cherry-pick it on top of release-2.4 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests |
@zhangyangyu @shiyuhang0 PLTA |
@zhangyangyu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests |
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e8a0526
|
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@xuanyu66: new pull request created: #2271. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@xuanyu66: new pull request created: #2272. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?