-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate SkyWalking-eyes to check license headers in CI #26956
Comments
Hi @fgksgf , Thanks for creating this issue! I think it is a good point we enable license checker in CI. In my opinion, you can directly create a PR and let's see how this action works on our repo. Then if it is good to go, we push it to merge. |
No problem, I will do this :) |
I locally checked the project with SkyWalking-eyes, and found that almost all license headers have one less sentence compared to the standard one. |
Well, the missing line is "WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.", I think this sentence is critical and a modified Apache license header is not called Apache license actually. It's better to add it back. |
I'm working on fixing them. |
Congrats! You just fixed an error from the Genesis Commit!!!!!! https://github.com/pingcap/tidb/blob/0d6f270068e8ff2aedc1c314e907771b6a508ebd/session.go |
@tisonkun We may need create an issue to track the ignored files in |
Yes. Would you like to create one for them? |
I'm creating the issue... |
as #27356 |
Enhancement
Integrate SkyWalking-eyes to check license headers in CI.
For some new contributors, they may do not know the license header is required, we can use the GitHub Action and check license headers in CI automatically.
The text was updated successfully, but these errors were encountered: