Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Backport to Fix response when user is removed from group #35571

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

phil-davis
Copy link
Contributor

When user is successfully removed from the group
fix message that is sent by server.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

When users are added/removed to the group the group counts should automatically updated. No error message should be seen in the console when users are added successfully to the group or deleted from the group. This PR focuses on the deletion part, though.

Related Issue

Motivation and Context

Fix the removal of user issue from the group from the UI. The issue was with togglegroups.php sending response data.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

When user is successfully removed from the group
fix message that is sent by server.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@phil-davis phil-davis requested a review from micbar June 18, 2019 06:28
@phil-davis phil-davis self-assigned this Jun 18, 2019
@phil-davis
Copy link
Contributor Author

phil-davis commented Jun 18, 2019

Original PR: owncloud-archive/user_management#188

Backport to release-10.2.1 #35570

I made this backport to stable10 because so far in making release-10.2.1 we have first put all the code into stable10 and then also cherry-picked the commits that are specially to go in release-10.2.1. There will be nothing to merge back from release-10.2.1

@phil-davis phil-davis changed the title [stabe10] Backport to Fix response when user is removed from group [stable10] Backport to Fix response when user is removed from group Jun 18, 2019
@phil-davis phil-davis merged commit 7c58bba into stable10 Jun 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-fix-user-group-toggle branch June 18, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants