Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.2.1] Backport to Fix response when user is removed from group #35570

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

sharidas
Copy link
Contributor

When user is successfully removed from the group
fix message that is sent by server.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

When users are added/removed to the group the group counts should automatically updated. No error message should be seen in the console when users are added successfully to the group or deleted from the group. This PR focuses on the deletion part, though.

Related Issue

Motivation and Context

Fix the removal of user issue from the group from the UI. The issue was with togglegroups.php sending response data.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@sharidas sharidas requested a review from micbar June 18, 2019 05:33
@sharidas sharidas self-assigned this Jun 18, 2019
@sharidas sharidas added this to the development milestone Jun 18, 2019
@sharidas
Copy link
Contributor Author

sharidas commented Jun 18, 2019

Original PR: owncloud-archive/user_management#188

core stable10 PR: #35571

@micbar
Copy link
Contributor

micbar commented Jun 18, 2019

@phil-davis seems that some Ci stuff is missing in this branch

@phil-davis
Copy link
Contributor

@micbar the acceptance test code and scenarios in rlease-10.2.1 are as they were 2 months ago - quite a few differences from current stable10
See #35562 which brings the acceptance test CI up-to-date in release-10.2.1

When user is successfully removed from the group
fix message that is sent by server.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@patrickjahns patrickjahns force-pushed the fix-user-group-toggle-10.2.1 branch from 740c31c to 56c7258 Compare June 18, 2019 12:14
@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-10.2.1@cf1a31a). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release-10.2.1   #35570   +/-   ##
=================================================
  Coverage                  ?   64.39%           
  Complexity                ?    20139           
=================================================
  Files                     ?     1286           
  Lines                     ?    77077           
  Branches                  ?     1308           
=================================================
  Hits                      ?    49630           
  Misses                    ?    27063           
  Partials                  ?      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (?) 0 <ø> (?)
#phpunit 65.52% <0%> (?) 20139 <0> (?)
Impacted Files Coverage Δ Complexity Δ
settings/ajax/togglegroups.php 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1a31a...56c7258. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #35570 into release-10.2.1 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.1   #35570      +/-   ##
====================================================
- Coverage             64.39%   64.39%   -0.01%     
  Complexity            20139    20139              
====================================================
  Files                  1286     1286              
  Lines                 77075    77077       +2     
  Branches               1308     1308              
====================================================
  Hits                  49630    49630              
- Misses                27061    27063       +2     
  Partials                384      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.52% <0%> (-0.01%) 20139 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
settings/ajax/togglegroups.php 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1a31a...56c7258. Read the comment docs.

@patrickjahns patrickjahns self-requested a review June 18, 2019 14:26
@patrickjahns patrickjahns merged commit 84a6660 into release-10.2.1 Jun 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-user-group-toggle-10.2.1 branch June 18, 2019 14:27
@patrickjahns patrickjahns modified the milestones: development, QA Jun 18, 2019
@davitol davitol mentioned this pull request Jun 25, 2019
11 tasks
@patrickjahns patrickjahns modified the milestone: QA Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants