Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.2: Remove user from a group results in an error #35289

Closed
cortho opened this issue May 21, 2019 · 7 comments
Closed

10.2: Remove user from a group results in an error #35289

cortho opened this issue May 21, 2019 · 7 comments
Assignees
Labels
p2-high Escalation, on top of current planning, release blocker regression Type:Bug
Milestone

Comments

@cortho
Copy link

cortho commented May 21, 2019

Steps to reproduce

  1. In the Users page add any user to any group
  2. Remove the group for this user
  3. The togglegroups.php AJAX call results with status: error
  4. In the JS console you will read response.data is undefined
  5. The user count in the group list at the left side is not reduced

Expected behaviour

No errors, the group list ist correctly updated

Actual behaviour

The AJAX call results in a status error breaking functionality in users.js when there is no response

Server configuration

Operating system:
Ubuntu 18.04.2 LTS

Web server:
apache2-2.4.29-1ubuntu4.6

Database:
mariadb-server-10.1 10.1.38-0ubuntu0.18.04.2

PHP version:
7.2.17-0ubuntu0.18.04.1

ownCloud version: (see ownCloud admin page)
10.2.0.5

Updated from an older ownCloud or fresh install:
fresh install

Where did you install ownCloud from:
owncloud.org download page

Are you using external storage, if yes which one: local/smb/sftp/...
no

Are you using encryption: yes/no
no

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
no

Client configuration

Browser:
Firefox 66.0.4

Operating system:
Ubuntu 18.04.2 LTS

Logs

Web server error log

no errors

ownCloud log (data/owncloud.log)

no errors

Browser log

see attached Screenshot

Selection_731

@davitol
Copy link
Contributor

davitol commented May 21, 2019

Tested in 10.2 and it is reproducible. Not reproducible in 10.1 so it is a regression

@cortho Refreshing the browser the group count shows the right number of users, does it happen to you too?

@cortho
Copy link
Author

cortho commented May 21, 2019

@davitol Yes, by refreshing the browser the correct count is shown.

I found this issue because one of our apps hooks in this functionality and is expecting a non-erroneous response from the ajax, when there was no error.

@micbar
Copy link
Contributor

micbar commented May 21, 2019

@pmaier1 Regression found. No breaking anything directly, but need reloading the page.

@pmaier1
Copy link
Contributor

pmaier1 commented May 27, 2019

Yes, please plan fixing @micbar.

@micbar micbar modified the milestones: backlog, development May 27, 2019
@micbar micbar added the p2-high Escalation, on top of current planning, release blocker label Jun 14, 2019
@micbar
Copy link
Contributor

micbar commented Jun 17, 2019

@micbar
Copy link
Contributor

micbar commented Jun 17, 2019

Introduced in https://github.com/owncloud/enterprise/issues/2598

@sharidas
Copy link
Contributor

sharidas commented Jun 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2-high Escalation, on top of current planning, release blocker regression Type:Bug
Projects
None yet
Development

No branches or pull requests

5 participants