Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Test user count is updated when user is removed from or added to a group #190

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Test user count is updated when user is removed from or added to a group #190

merged 2 commits into from
Jun 24, 2019

Conversation

paurakhsharma
Copy link
Contributor

Description

Test user count is updated (without refreshing the page) when the user is removed from or added to a group

Related Issue

owncloud/core#35289

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@paurakhsharma paurakhsharma self-assigned this Jun 21, 2019
dpakach
dpakach reviewed Jun 21, 2019
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #190   +/-   ##
=========================================
  Coverage     78.63%   78.63%           
  Complexity      214      214           
=========================================
  Files            26       26           
  Lines           922      922           
=========================================
  Hits            725      725           
  Misses          197      197

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac44651...3246ec3. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 21, 2019 •
edited
Loading

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #190   +/-   ##
=========================================
  Coverage     78.63%   78.63%           
  Complexity      214      214           
=========================================
  Files            26       26           
  Lines           922      922           
=========================================
  Hits            725      725           
  Misses          197      197

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa135a0...bef6a5a. Read the comment docs.

@phil-davis
Copy link
Contributor

@paurakhsharma conflicts to resolve.
I can review after that...

@paurakhsharma paurakhsharma force-pushed the test-user-remove-from-group branch 2 times, most recently from abf1331 to f92ad5c Compare June 24, 2019 06:50
@paurakhsharma
Copy link
Contributor Author

@phil-davis ready for review.

paurakhsharma
paurakhsharma commented Jun 24, 2019
View reviewed changes
tests/acceptance/features/lib/UsersPage.php
@@ -823,6 +826,14 @@ public function addOrRemoveUserToGroup(Session $session, $user, $group, $add=tru
$groupLabel->click();
$this->waitForAjaxCallsToStartAndFinish($session);
}
$activeDropDown = $this->find('xpath', $this->activeDropDownXpath);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required because previously this method didn't close the group select dropdown after this method's job is complete (which is adding a user to a group or removing them from the group). Now, to perform other action (such as adding another user to a group) on the webUI after user is added or removed from the group the dropdown needs to be closed.

skshetry
skshetry reviewed Jun 24, 2019
View reviewed changes
Copy link
Contributor

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@paurakhsharma paurakhsharma force-pushed the test-user-remove-from-group branch from f92ad5c to a8ae182 Compare June 24, 2019 08:28
@paurakhsharma paurakhsharma requested a review from phil-davis June 24, 2019 08:29
@phil-davis
Copy link
Contributor

@paurakhsharma please backport to core stable10

@paurakhsharma paurakhsharma merged commit 3d57158 into master Jun 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the test-user-remove-from-group branch June 24, 2019 10:49
@paurakhsharma
Copy link
Contributor Author

#187 needs to merge first before I create backport for this.

@paurakhsharma
Copy link
Contributor Author

Oh my bad, backport of #187 is already merged. But the original PR isn't.

@paurakhsharma paurakhsharma mentioned this pull request Jun 24, 2019
Merged
@paurakhsharma
Copy link
Contributor Author

Backport on: owncloud/core#35639

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@skshetry skshetry skshetry left review comments

@dpakach dpakach dpakach left review comments

@phil-davis phil-davis phil-davis approved these changes

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

Assignees

@paurakhsharma paurakhsharma

Labels
4 - To release dev:acceptance-tests QA-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paurakhsharma @phil-davis @skshetry @dpakach