Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Fix response when user is removed from group #188

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Conversation

sharidas
Copy link
Contributor

When user is successfully removed from the group
fix message that is sent by server.

Signed-off-by: Sujith H sharidasan@owncloud.com

When user is successfully removed from the group
fix message that is sent by server.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas added this to the development milestone Jun 17, 2019
@sharidas sharidas self-assigned this Jun 17, 2019
@sharidas
Copy link
Contributor Author

sharidas commented Jun 17, 2019

Description

When users are added/removed to the group the group counts should automatically updated. No error message should be seen in the console when users are added successfully to the group or deleted from the group. This PR focuses on the deletion part, though.

Issue

Test done

  • Create 2 groups group1 and group2.
  • Create users user1, user2, user3,user4 ,user5 ,user6.
  • Add user1, user2, user3 to group1 and user4, user5,user6 to group2.
  • Now the numbers associated with group1 and group2 are 3 each.
  • Add user6 to group1. Now user should see group1 count is incremented to 4.
  • The web console does not show any error.

Here is the screenshot:
everyone

After removing user6 from group1, the value of group1 is set back to 3 as shown in this screenshot:
after-remove

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #188 into master will decrease coverage by 0.17%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
- Coverage      78.8%   78.63%   -0.18%     
  Complexity      214      214              
============================================
  Files            26       26              
  Lines           920      922       +2     
============================================
  Hits            725      725              
- Misses          195      197       +2
Impacted Files Coverage Δ Complexity Δ
ajax/togglegroups.php 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1bd7d...56fdc22. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #188 into master will decrease coverage by 0.17%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
- Coverage      78.8%   78.63%   -0.18%     
  Complexity      214      214              
============================================
  Files            26       26              
  Lines           920      922       +2     
============================================
  Hits            725      725              
- Misses          195      197       +2
Impacted Files Coverage Δ Complexity Δ
ajax/togglegroups.php 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1bd7d...56fdc22. Read the comment docs.

@sharidas
Copy link
Contributor Author

sharidas commented Jun 18, 2019

Backport to core release-10.2.1: owncloud/core#35570
Backport to core stable10 owncloud/core#35571

@sharidas
Copy link
Contributor Author

Kindly merge this PR please, the backports are merged.

@phil-davis
Copy link
Contributor

@micbar @DeepDiver1975 merge requested ^

@micbar micbar merged commit ac44651 into master Jun 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-user-group-toggle branch June 21, 2019 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants