Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update license headers to 2024 #16168

Merged
merged 6 commits into from
Jan 1, 2024
Merged

Update license headers to 2024 #16168

merged 6 commits into from
Jan 1, 2024
+11,800 −11,876

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jan 1, 2024 •
edited
Loading

This time performed by mvn license:format after some issues preventing a clean mvn update were fixed last year:

Some headers still had to be manually updated:

  • nibeheatpump (.cpp/.h/.ino extensions not included)
  • smsmodem (openHAB header in 3rdparty directory)
  • hueemulation (openHAB header in non-openHAB namespace)
  • addon-header.xml (regression of Build addon xml #15870 - FYI @J-N-K )

Verification method used:

  • Created a separate branch with a commit of search & replaced license headers
  • Compared the two branches.
  • The other branch had 11798 lines added. This is two less than this one, which is explained by the two lines changed in the first commit.
  • The count of lines removed is different. I manually went through all differences, and they are explained by some headers with excess lines. Two examples below.

Excess line type 1 (after header):

openhab-addons/bundles/org.openhab.automation.jrubyscripting/src/main/java/org/openhab/automation/jrubyscripting/internal/package-info.java

Lines 11 to 14 in c52b684

* SPDX-License-Identifier: EPL-2.0
*/
@org.osgi.annotation.bundle.Header(name = org.osgi.framework.Constants.DYNAMICIMPORT_PACKAGE, value = "*")

Excess line type 2 (inside header):

openhab-addons/bundles/org.openhab.binding.govee/src/main/java/org/openhab/binding/govee/internal/model/Color.java

Lines 11 to 13 in c52b684

* SPDX-License-Identifier: EPL-2.0
*
*/

Previous iteration: #14154

@jlaur jlaur mentioned this pull request Jan 1, 2024
Merged
jlaur added 2 commits January 1, 2024 16:14
@jlaur
Update copyright year in configuration
59a2b9a 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur
Update license headers
c79f283 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur force-pushed the copyright_headers branch from a452d54 to c79f283 Compare January 1, 2024 15:17
jlaur added 4 commits January 1, 2024 16:19
@jlaur
Manually update nibeheatpump headers (.cpp/.h/.ino)
da0bdd4 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur
Manually update smsmodem header
0216460 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur
Manually update hueemulation header
2b37c0c 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur
Manually update addon-header.xml header
d941dc0 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur marked this pull request as ready for review January 1, 2024 17:08
kaikreuzer
kaikreuzer approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds pretty good - thanks for the header updates!

@kaikreuzer kaikreuzer merged commit f4596f5 into openhab:main Jan 1, 2024
2 checks passed
@kaikreuzer kaikreuzer added this to the 4.2 milestone Jan 1, 2024
@jlaur jlaur deleted the copyright_headers branch January 1, 2024 19:56
Cybso pushed a commit to Cybso/openhab-addons that referenced this pull request Jan 5, 2024
@jlaur @Cybso
Update license headers to 2024 (openhab#16168)
06a9783 
* Update copyright year in configuration
* Update license headers
* Manually update nibeheatpump headers (.cpp/.h/.ino)
* Manually update smsmodem header
* Manually update hueemulation header
* Manually update addon-header.xml header

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@jlaur @austvik
Update license headers to 2024 (openhab#16168)
445a5fe 
* Update copyright year in configuration
* Update license headers
* Manually update nibeheatpump headers (.cpp/.h/.ino)
* Manually update smsmodem header
* Manually update hueemulation header
* Manually update addon-header.xml header

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
florian-h05 pushed a commit to florian-h05/openhab-addons that referenced this pull request May 30, 2024
@jlaur @florian-h05
Update license headers to 2024 (openhab#16168)
12c1be4 
* Update copyright year in configuration
* Update license headers
* Manually update nibeheatpump headers (.cpp/.h/.ino)
* Manually update smsmodem header
* Manually update hueemulation header
* Manually update addon-header.xml header

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

(cherry picked from commit f4596f5)
@jlaur jlaur mentioned this pull request Jun 28, 2024
Merged
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@jlaur @joni1993
Update license headers to 2024 (openhab#16168)
4018834 
* Update copyright year in configuration
* Update license headers
* Manually update nibeheatpump headers (.cpp/.h/.ino)
* Manually update smsmodem header
* Manually update hueemulation header
* Manually update addon-header.xml header

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur mentioned this pull request Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

@Hilbrand Hilbrand Awaiting requested review from Hilbrand Hilbrand is a code owner

@fa2k fa2k Awaiting requested review from fa2k fa2k is a code owner

@goopilot goopilot Awaiting requested review from goopilot goopilot is a code owner

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

@pfink pfink Awaiting requested review from pfink pfink is a code owner

@Andy2003 Andy2003 Awaiting requested review from Andy2003 Andy2003 is a code owner

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

@Nebula83 Nebula83 Awaiting requested review from Nebula83 Nebula83 is a code owner

@florian-h05 florian-h05 Awaiting requested review from florian-h05 florian-h05 is a code owner

@mlobstein mlobstein Awaiting requested review from mlobstein mlobstein is a code owner

@klocsson klocsson Awaiting requested review from klocsson klocsson is a code owner

@fruggy83 fruggy83 Awaiting requested review from fruggy83 fruggy83 is a code owner

@gdolfen gdolfen Awaiting requested review from gdolfen gdolfen is a code owner

@hmerk hmerk Awaiting requested review from hmerk hmerk is a code owner

@mherwege mherwege Awaiting requested review from mherwege mherwege is a code owner

@jannegpriv jannegpriv Awaiting requested review from jannegpriv

@maniac103 maniac103 Awaiting requested review from maniac103 maniac103 is a code owner

@sibbi77 sibbi77 Awaiting requested review from sibbi77 sibbi77 is a code owner

@mhilbush mhilbush Awaiting requested review from mhilbush mhilbush is a code owner

@alexf2015 alexf2015 Awaiting requested review from alexf2015 alexf2015 is a code owner

@limdul79 limdul79 Awaiting requested review from limdul79 limdul79 is a code owner

@DerOetzi DerOetzi Awaiting requested review from DerOetzi DerOetzi is a code owner

@RSStephens RSStephens Awaiting requested review from RSStephens RSStephens is a code owner

@andrew-schofield andrew-schofield Awaiting requested review from andrew-schofield andrew-schofield is a code owner

@Friesoch Friesoch Awaiting requested review from Friesoch Friesoch is a code owner

@MikeJMajor MikeJMajor Awaiting requested review from MikeJMajor MikeJMajor is a code owner

@rmichalak rmichalak Awaiting requested review from rmichalak rmichalak is a code owner

@soenkekueper soenkekueper Awaiting requested review from soenkekueper soenkekueper is a code owner

@jwveldhuis jwveldhuis Awaiting requested review from jwveldhuis jwveldhuis is a code owner

@J-N-K J-N-K Awaiting requested review from J-N-K J-N-K is a code owner

@lujop lujop Awaiting requested review from lujop lujop is a code owner

@pravussum pravussum Awaiting requested review from pravussum pravussum is a code owner

@rs22 rs22 Awaiting requested review from rs22 rs22 is a code owner

@caffineehacker caffineehacker Awaiting requested review from caffineehacker caffineehacker is a code owner

@boehan boehan Awaiting requested review from boehan boehan is a code owner

@BobRak BobRak Awaiting requested review from BobRak BobRak is a code owner

@jpharvey jpharvey Awaiting requested review from jpharvey jpharvey is a code owner

@gedejong gedejong Awaiting requested review from gedejong gedejong is a code owner

@MrRonfo MrRonfo Awaiting requested review from MrRonfo MrRonfo is a code owner

@hypetsch hypetsch Awaiting requested review from hypetsch hypetsch is a code owner

@marvkis marvkis Awaiting requested review from marvkis marvkis is a code owner

@tratho tratho Awaiting requested review from tratho tratho is a code owner

@david-pace david-pace Awaiting requested review from david-pace david-pace is a code owner

@GerdZanker GerdZanker Awaiting requested review from GerdZanker GerdZanker is a code owner

@jofleck jofleck Awaiting requested review from jofleck jofleck is a code owner

@ccutrer ccutrer Awaiting requested review from ccutrer ccutrer is a code owner

@cpmeister cpmeister Awaiting requested review from cpmeister cpmeister is a code owner

@tisoft tisoft Awaiting requested review from tisoft tisoft is a code owner

@blafois blafois Awaiting requested review from blafois blafois is a code owner

@cdjackson cdjackson Awaiting requested review from cdjackson cdjackson is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@Wolfgang1966 Wolfgang1966 Awaiting requested review from Wolfgang1966 Wolfgang1966 is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@digitaldan digitaldan Awaiting requested review from digitaldan digitaldan is a code owner

@gerrieg gerrieg Awaiting requested review from gerrieg

@paphko paphko Awaiting requested review from paphko paphko is a code owner

@morph166955 morph166955 Awaiting requested review from morph166955 morph166955 is a code owner

@GiviMAD GiviMAD Awaiting requested review from GiviMAD GiviMAD is a code owner

@mgeramb mgeramb Awaiting requested review from mgeramb mgeramb is a code owner

@dominicdesu dominicdesu Awaiting requested review from dominicdesu dominicdesu is a code owner

@bobadair bobadair Awaiting requested review from bobadair bobadair is a code owner

@billfor billfor Awaiting requested review from billfor billfor is a code owner

@3cky 3cky Awaiting requested review from 3cky 3cky is a code owner

@aurelio1 aurelio1 Awaiting requested review from aurelio1 aurelio1 is a code owner

@fwolter fwolter Awaiting requested review from fwolter fwolter is a code owner

@wborn wborn Awaiting requested review from wborn wborn is a code owner

@jimtng jimtng Awaiting requested review from jimtng jimtng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jlaur @kaikreuzer