-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lametrictime] Move external library to internal code #14425
Conversation
Signed-off-by: Kai Kreuzer <kai@openhab.org>
The POJOs could be moved to a folder with the name |
Yep, for SleepIQ, I just renamed the |
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Thanks, that's a good hint, I didn't know this feature yet! |
Awesome, thanks for the effort put into this @kaikreuzer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
See #14165 (comment)
Remarks:
src/main/java
(andsrc/test/java
for tests).src/3rdparty/java
, since there are still some external CDDL classes left.license:format
.I didn't address SAT warnings wrt null annotations as a lot of code are pojos that do not really benefit from it and which would have meant significant effort.