Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lametrictime] Move external library to internal code #14425

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer kaikreuzer commented Feb 17, 2023

See #14165 (comment)

Remarks:

  • I moved @syphr42 library code to src/main/java (and src/test/java for tests).
  • I couldn't remove src/3rdparty/java, since there are still some external CDDL classes left.
  • The CDDL classes do not have openHAB license header, so they won't be an issue for license:format.
  • I addressed all SAT errors like missing Javadoc headers and author tags.
  • I didn't address SAT warnings wrt null annotations as a lot of code are pojos that do not really benefit from it and which would have meant significant effort.

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@jlaur
Copy link
Contributor

jlaur commented Feb 17, 2023

  • I didn't address SAT warnings wrt null annotations as a lot of code are pojos that do not really benefit from it and which would have meant significant effort.

The POJOs could be moved to a folder with the name dto, in which case SAT will not complain about missing null annotations.

@mhilbush
Copy link
Contributor

The POJOs could be moved to a folder with the name dto

Yep, for SleepIQ, I just renamed the model directory to dto.

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member Author

Thanks, that's a good hint, I didn't know this feature yet!
I've moved the model classes and added null annotations to all other classes now.

@kaikreuzer kaikreuzer requested a review from jlaur February 18, 2023 13:43
@jlaur
Copy link
Contributor

jlaur commented Feb 18, 2023

I've moved the model classes and added null annotations to all other classes now.

Awesome, thanks for the effort put into this @kaikreuzer.

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit ce41708 into openhab:main Feb 18, 2023
@jlaur jlaur added this to the 4.0 milestone Feb 18, 2023
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants