Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[paradoxalarm] Fix namespaces for tests #14156

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jan 4, 2023

The used namespaces prevented the license headers from being updated with the command mvn license:format.

Related to #14154

@jlaur jlaur added the test label Jan 4, 2023
@jlaur jlaur requested a review from theater as a code owner January 4, 2023 19:04
@jlaur jlaur requested a review from a team January 4, 2023 19:04
@jlaur jlaur marked this pull request as draft January 4, 2023 22:00
@jlaur
Copy link
Contributor Author

jlaur commented Jan 4, 2023

Marking as draft to avoid collision with #14154. No longer coupled since mvn license:format cannot be used.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur force-pushed the paradoxalarm-fix-namespaces branch from 1245965 to c854933 Compare January 6, 2023 15:23
@jlaur jlaur marked this pull request as ready for review January 6, 2023 15:23
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 896ea13 into openhab:main Jan 6, 2023
@lolodomo lolodomo added this to the 4.0 milestone Jan 6, 2023
@jlaur jlaur deleted the paradoxalarm-fix-namespaces branch January 6, 2023 20:22
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants