Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update license headers to 2025 #18015

Merged
merged 3 commits into from
Jan 1, 2025
Merged

Update license headers to 2025 #18015

merged 3 commits into from
Jan 1, 2025

Conversation

wborn
Copy link
Member

@wborn wborn commented Jan 1, 2025 •
edited
Loading

Updates the license headers to 2025.

@kaikreuzer
Copy link
Member

I guess you will need to adapt https://github.com/openhab/openhab-core/blob/main/tools/static-code-analysis/checkstyle/ruleset.properties#L4 as well.

@wborn
Copy link
Member Author

wborn commented Jan 1, 2025

There are also issues with the ParameterizedRegexpHeaderCheck as it only works for headers starting with /**.

The license-maven-plugin nowadays uses /* for Java, Groovy headers as default as it is more common and prevents tooling issues, see mathieucarbou/license-maven-plugin#109.

I can create a PR for SAT to fix this. 🙂

@kaikreuzer
Copy link
Member

I can create a PR for SAT to fix this. 🙂

That would be nice.
I'd suggest to decouple the change of the year and the header syntax then into separate PRs.

@wborn
Update license headers to 2025
0ad6a2d 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn force-pushed the update-license-headers branch from b5cf4b7 to 0ad6a2d Compare January 1, 2025 15:02
@wborn
Fix indentation
00782f9 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this pull request Jan 1, 2025
Merged
@wborn
Fix more headers
9f5cc04 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this pull request Jan 1, 2025
Merged
holgerfriedrich
holgerfriedrich approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 1, 2025
@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 1, 2025
@lsiepel lsiepel merged commit d647604 into openhab:main Jan 1, 2025
2 of 3 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Jan 1, 2025
@wborn wborn deleted the update-license-headers branch January 1, 2025 23:44
@jlaur
Copy link
Contributor

jlaur commented Jan 2, 2025

@wborn - out of curiosity, how well did mvn license:format work this year? I had a few issues last time, see #16168.

@wborn
Copy link
Member Author

wborn commented Jan 2, 2025

Still some manual changes were needed, see the 9f5cc04 commit.

DrRSatzteil pushed a commit to DrRSatzteil/openhab-addons that referenced this pull request Jan 3, 2025
@wborn @DrRSatzteil
Update license headers to 2025 (openhab#18015)
7dfdc82 
* Update license headers to 2025

Signed-off-by: Wouter Born <github@maindrain.net>
@holgerfriedrich holgerfriedrich mentioned this pull request Jan 5, 2025
Merged
@jlaur jlaur mentioned this pull request Jan 6, 2025
Open
chilobo pushed a commit to chilobo/openhab-addons that referenced this pull request Feb 10, 2025
@wborn @chilobo
Update license headers to 2025 (openhab#18015)
8b928ad 
* Update license headers to 2025

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

@fruggy83 fruggy83 Awaiting requested review from fruggy83 fruggy83 is a code owner

@gdolfen gdolfen Awaiting requested review from gdolfen gdolfen is a code owner

@jlaur jlaur Awaiting requested review from jlaur jlaur is a code owner

@hmerk hmerk Awaiting requested review from hmerk hmerk is a code owner

@mherwege mherwege Awaiting requested review from mherwege mherwege is a code owner

@jannegpriv jannegpriv Awaiting requested review from jannegpriv jannegpriv is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

@maniac103 maniac103 Awaiting requested review from maniac103 maniac103 is a code owner

@sibbi77 sibbi77 Awaiting requested review from sibbi77 sibbi77 is a code owner

@mhilbush mhilbush Awaiting requested review from mhilbush mhilbush is a code owner

@alexf2015 alexf2015 Awaiting requested review from alexf2015 alexf2015 is a code owner

@limdul79 limdul79 Awaiting requested review from limdul79 limdul79 is a code owner

@DerOetzi DerOetzi Awaiting requested review from DerOetzi DerOetzi is a code owner

@Hilbrand Hilbrand Awaiting requested review from Hilbrand Hilbrand is a code owner

@RSStephens RSStephens Awaiting requested review from RSStephens RSStephens is a code owner

@andrew-schofield andrew-schofield Awaiting requested review from andrew-schofield andrew-schofield is a code owner

@Friesoch Friesoch Awaiting requested review from Friesoch Friesoch is a code owner

@MikeJMajor MikeJMajor Awaiting requested review from MikeJMajor MikeJMajor is a code owner

@rmichalak rmichalak Awaiting requested review from rmichalak rmichalak is a code owner

@soenkekueper soenkekueper Awaiting requested review from soenkekueper soenkekueper is a code owner

@jwveldhuis jwveldhuis Awaiting requested review from jwveldhuis jwveldhuis is a code owner

@J-N-K J-N-K Awaiting requested review from J-N-K J-N-K is a code owner

@lujop lujop Awaiting requested review from lujop lujop is a code owner

@pravussum pravussum Awaiting requested review from pravussum pravussum is a code owner

@rs22 rs22 Awaiting requested review from rs22 rs22 is a code owner

@caffineehacker caffineehacker Awaiting requested review from caffineehacker caffineehacker is a code owner

@boehan boehan Awaiting requested review from boehan boehan is a code owner

@BobRak BobRak Awaiting requested review from BobRak BobRak is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

@jpharvey jpharvey Awaiting requested review from jpharvey jpharvey is a code owner

@gedejong gedejong Awaiting requested review from gedejong gedejong is a code owner

@MrRonfo MrRonfo Awaiting requested review from MrRonfo MrRonfo is a code owner

@hypetsch hypetsch Awaiting requested review from hypetsch hypetsch is a code owner

@marvkis marvkis Awaiting requested review from marvkis marvkis is a code owner

@tratho tratho Awaiting requested review from tratho tratho is a code owner

@david-pace david-pace Awaiting requested review from david-pace david-pace is a code owner

@GerdZanker GerdZanker Awaiting requested review from GerdZanker GerdZanker is a code owner

@jofleck jofleck Awaiting requested review from jofleck jofleck is a code owner

@ccutrer ccutrer Awaiting requested review from ccutrer ccutrer is a code owner

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

@cpmeister cpmeister Awaiting requested review from cpmeister cpmeister is a code owner

@andrewfg andrewfg Awaiting requested review from andrewfg andrewfg is a code owner

@tisoft tisoft Awaiting requested review from tisoft tisoft is a code owner

@pfink pfink Awaiting requested review from pfink pfink is a code owner

@blafois blafois Awaiting requested review from blafois blafois is a code owner

@cdjackson cdjackson Awaiting requested review from cdjackson cdjackson is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@mlobstein mlobstein Awaiting requested review from mlobstein mlobstein is a code owner

@Wolfgang1966 Wolfgang1966 Awaiting requested review from Wolfgang1966 Wolfgang1966 is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@digitaldan digitaldan Awaiting requested review from digitaldan digitaldan is a code owner

@paphko paphko Awaiting requested review from paphko paphko is a code owner

@morph166955 morph166955 Awaiting requested review from morph166955 morph166955 is a code owner

@GiviMAD GiviMAD Awaiting requested review from GiviMAD GiviMAD is a code owner

@psmedley psmedley Awaiting requested review from psmedley psmedley is a code owner

@mgeramb mgeramb Awaiting requested review from mgeramb mgeramb is a code owner

@dominicdesu dominicdesu Awaiting requested review from dominicdesu dominicdesu is a code owner

@bobadair bobadair Awaiting requested review from bobadair bobadair is a code owner

@billfor billfor Awaiting requested review from billfor billfor is a code owner

@3cky 3cky Awaiting requested review from 3cky 3cky is a code owner

@aurelio1 aurelio1 Awaiting requested review from aurelio1 aurelio1 is a code owner

@fwolter fwolter Awaiting requested review from fwolter fwolter is a code owner

@HolgerHees HolgerHees Awaiting requested review from HolgerHees HolgerHees is a code owner

@florian-h05 florian-h05 Awaiting requested review from florian-h05 florian-h05 is a code owner

@jimtng jimtng Awaiting requested review from jimtng jimtng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wborn @kaikreuzer @jlaur @holgerfriedrich @lsiepel