Rename host metrics according to metrics spec #2311
Conversation
| metric := pdata.NewMetric() | ||
| metric.SetName("system.processes.blocked") |
There was a problem hiding this comment.
This is the only place where I haven't followed the spec. The spec actually says this should be "system.processes.count", but I think it may make more sense to get the spec changed as otherwise this will very confusing with the "per process" metrics.
FYI @aabmass
3c5eee9 to
57956cc
Compare
| @@ -12,13 +12,13 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| // +build windows | |||
There was a problem hiding this comment.
Make Linux the special case instead of Windows, as other systems including Darwin seem to use the same standard names as Windows.
Codecov Report
@@ Coverage Diff @@
## master #2311 +/- ##
==========================================
+ Coverage 92.04% 92.07% +0.03%
==========================================
Files 272 273 +1
Lines 15337 15358 +21
==========================================
+ Hits 14117 14141 +24
+ Misses 840 837 -3
Partials 380 380
Continue to review full report at Codecov.
|
2087b9e to
a8ba26e
Compare
a8ba26e to
77abe90
Compare
| metric.SetName("system.processes.running") | ||
| metric.SetDescription("Total number of running processes.") | ||
| metric.SetUnit("1") | ||
| metric.SetName("system.processes.created") |
There was a problem hiding this comment.
Looks like this one should be added to the spec as well
There was a problem hiding this comment.
Indeed, @aabmass can you take this as an action item?
There was a problem hiding this comment.
Since open-telemetry/opentelemetry-collector#2311, 'swap' is known as 'paging'.
Since open-telemetry/opentelemetry-collector#2311, 'swap' is known as 'paging'.
Link to tracking Issue: #2220
Description: Update all metric names / descriptions to match the specification.
This PR also adds a couple of minor features for Linux that have recently been added to gopsutil:
Note there are some major breaking changes in this PR:
swapscraper changed topagingscraper, config will need to be updated accordingly