Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update system metrics semantic conventions with collector changes #1299

Closed
aabmass opened this issue Dec 21, 2020 · 2 comments · Fixed by #1308
Closed

Update system metrics semantic conventions with collector changes #1299

aabmass opened this issue Dec 21, 2020 · 2 comments · Fixed by #1308
Assignees
@aabmass
Labels
area:semantic-conventions Related to semantic conventions priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory

Comments

@aabmass
Copy link
Member

aabmass commented Dec 21, 2020

What are you trying to achieve?

Have collector and spec use the same system metric names. system.process.count should be renamed to system.processes.count and system.processes.created should be added.

Additional context.

open-telemetry/opentelemetry-collector#2311
@aabmass aabmass added the spec:metrics Related to the specification/metrics directory label Dec 21, 2020
@aabmass
Copy link
Member Author

aabmass commented Dec 21, 2020

This can be assigned to me

@Oberon00 Oberon00 added the area:semantic-conventions Related to semantic conventions label Dec 21, 2020
@aabmass aabmass mentioned this issue Dec 21, 2020
Merged
@andrewhsu andrewhsu added priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Dec 22, 2020
@aabmass aabmass mentioned this issue Dec 28, 2020
Merged
@carlosalberto
Copy link
Contributor

cc @open-telemetry/specs-metrics-approvers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aabmass aabmass

Labels
area:semantic-conventions Related to semantic conventions priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update system metrics with changes from collector aabmass/opentelemetry-specification
4 participants
@andrewhsu @carlosalberto @Oberon00 @aabmass