Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/signalfx: Use updated network metric name #2160

Merged

Conversation

asuresh4
Copy link
Member

@asuresh4 asuresh4 commented Jan 21, 2021

Description: Update usages of system.network.dropped_packets to system.network.dropped as a result of open-telemetry/opentelemetry-collector#2311.

The occurrence in translation/constants.go is being removed here #2161

@asuresh4 asuresh4 requested a review from a team January 21, 2021 01:14
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #2160 (32bedb4) into master (9f137ea) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2160      +/-   ##
==========================================
+ Coverage   90.37%   90.40%   +0.03%     
==========================================
  Files         397      397              
  Lines       19506    19506              
==========================================
+ Hits        17628    17635       +7     
+ Misses       1416     1406      -10     
- Partials      462      465       +3     
Flag Coverage Δ
integration 69.75% <ø> (+0.06%) ⬆️
unit 89.19% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
processor/groupbytraceprocessor/event.go 96.00% <0.00%> (-0.80%) ⬇️
receiver/carbonreceiver/transport/tcp_server.go 67.00% <0.00%> (+1.00%) ⬆️
receiver/prometheusexecreceiver/receiver.go 88.33% <0.00%> (+2.50%) ⬆️
receiver/redisreceiver/interval/interval_runner.go 42.10% <0.00%> (+21.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f137ea...32bedb4. Read the comment docs.

@asuresh4 asuresh4 force-pushed the sfxexporter-fixup-metric branch from e67b505 to 32bedb4 Compare January 21, 2021 14:45
@bogdandrutu bogdandrutu merged commit b028ab9 into open-telemetry:master Jan 21, 2021
@asuresh4 asuresh4 deleted the sfxexporter-fixup-metric branch January 22, 2021 00:53
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Add benchmarks for error handler

* All multiple global ErrorHandler sets

* Use ioutil instead of io for Discard

* Add changes to changelog

* Add unit tests for delegation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants