Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/signalfx: Reinstate network/filesystem translation rules #2171

Merged

Conversation

asuresh4
Copy link
Member

@asuresh4 asuresh4 commented Jan 22, 2021

Description: Reinstate network/filesystem translations.

@asuresh4 asuresh4 requested a review from a team January 22, 2021 17:29
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #2171 (2ebd904) into master (6906dd9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2171   +/-   ##
=======================================
  Coverage   90.44%   90.44%           
=======================================
  Files         397      397           
  Lines       19565    19565           
=======================================
+ Hits        17695    17696    +1     
+ Misses       1407     1406    -1     
  Partials      463      463           
Flag Coverage Δ
integration 69.41% <ø> (+0.06%) ⬆️
unit 89.24% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
processor/groupbytraceprocessor/event.go 96.77% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6906dd9...2ebd904. Read the comment docs.

@asuresh4 asuresh4 force-pushed the sfxexporter-fix-translations branch from 067ba36 to 2ebd904 Compare January 22, 2021 21:37
@bogdandrutu bogdandrutu merged commit 88a8c82 into open-telemetry:master Jan 27, 2021
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Otherwise, static analysis tools are not very useful on this package and the interface types are introduced arbitarily not because of need.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants