[extension/ecsobserver] Init service client and mock #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiamxia
reviewed
May 3, 2021
mxiamxia
reviewed
May 3, 2021
mxiamxia
reviewed
May 3, 2021
e229624 to
1915ccf
Compare
mxiamxia
approved these changes
May 3, 2021
anuraaga
reviewed
May 7, 2021
There was a problem hiding this comment.
As we're moving towards GA we need to be careful on keeping exposed API to a minimum. Can you skim through all the current PRs and make sure structs, methods, and constants are all either
- public to implement a collector interface
- private
- Subpackage of
internal
?
- Implement get all tasks - Pacakge `ecsmock` provides ECS service API for a single cluster.
d06ad37 to
48f66eb
Compare
It should get moved into internal/aws in the future. Keep it under extension package for now
48f66eb to
10a06a2
Compare
|
@anuraaga PTAL |
anuraaga
approved these changes
May 11, 2021
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
* Add overview and move to seperate godoc * Move config overview to doc.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ecsmockmocks ECS service API for a single cluster. Might move it intointernal/awsonce aws: Move duplicated ECS metadata clients into internal/aws #3188 is done.Link to tracking Issue:
Pending PRs
Previous PRs
Testing:
unit test
Documentation:
No new doc. See existing doc