Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/ecsobserver] Add service and task definition based matcher #3386

Merged
merged 5 commits into from
Jun 1, 2021

Conversation

pingleig
Copy link
Contributor

Description:

  • Implement match task by service name (like k8s deployment name)
  • Implement match task by task definition (btw: it is not same as service name, like pod template 'name')

Link to tracking Issue:

Pending PRs

Previous PRs

Testing:

unit test

Documentation:

No new doc. See existing doc

@pingleig pingleig requested a review from jrcamp as a code owner May 14, 2021 01:24
@pingleig pingleig requested a review from a team May 14, 2021 01:24
@pingleig
Copy link
Contributor Author

cc @Aneurysm9 @anuraaga

extension/observer/ecsobserver/matcher.go Outdated Show resolved Hide resolved
extension/observer/ecsobserver/matcher.go Outdated Show resolved Hide resolved
extension/observer/ecsobserver/matcher.go Outdated Show resolved Hide resolved
extension/observer/ecsobserver/service.go Outdated Show resolved Hide resolved
extension/observer/ecsobserver/service.go Outdated Show resolved Hide resolved
extension/observer/ecsobserver/service.go Outdated Show resolved Hide resolved
@pingleig
Copy link
Contributor Author

ping @anuraaga btw: there is also #3333

@pingleig pingleig force-pushed the ecss-matcher-service branch from 27af161 to 191991f Compare May 25, 2021 19:18
@bogdandrutu bogdandrutu merged commit 9cbbec7 into open-telemetry:main Jun 1, 2021
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
…otlprecv (#3386)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants