-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/ecsobserver] Add service and task definition based matcher #3386
Merged
bogdandrutu
merged 5 commits into
open-telemetry:main
from
pingleig:ecss-matcher-service
Jun 1, 2021
Merged
[extension/ecsobserver] Add service and task definition based matcher #3386
bogdandrutu
merged 5 commits into
open-telemetry:main
from
pingleig:ecss-matcher-service
Jun 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
May 14, 2021
anuraaga
reviewed
May 14, 2021
anuraaga
approved these changes
May 25, 2021
Will be used in sd.go when fetcher is ready
- Implement `Validate` on top level config struct so error should show up earlier when loading the config.
pingleig
force-pushed
the
ecss-matcher-service
branch
from
May 25, 2021 19:18
27af161
to
191991f
Compare
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
…otlprecv (#3386) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
Pending PRs
Previous PRs
Testing:
unit test
Documentation:
No new doc. See existing doc