You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For #1395 prometheus ecs discovery, we need cluster detection using ECS metada API so user don't need to config it manually. We can't make use of neither components along the pipeline. The extension runs at the start of the pipeline and needs the cluster name to generate a prometheus file sd config for receiver.
Describe the solution you'd like
There is a internal/aws package for sharing common aws specific logic. There is no official ECS metada client (and struct definitions). I think we should merge into the common logic to a package like internal/aws/ecsutil
Describe alternatives you've considered
It's possible to import resource detector processor in other components but it's kind of strange and makes the dependency more complex.
Additional context
N/A
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Currently there are two places using ECS metadata endpoint to get info like cluster name
resourcedetectionprocessor/internal/aws/ecs
awsecscontainermetricsreceiver
opentelemetry-collector-contrib/processor/resourcedetectionprocessor/internal/aws/ecs/metadata_ecs.go
Line 24 in 88782b0
opentelemetry-collector-contrib/receiver/awsecscontainermetricsreceiver/awsecscontainermetrics/metadata.go
Line 18 in e663b59
For #1395 prometheus ecs discovery, we need cluster detection using ECS metada API so user don't need to config it manually. We can't make use of neither components along the pipeline. The extension runs at the start of the pipeline and needs the cluster name to generate a prometheus file sd config for receiver.
Describe the solution you'd like
There is a
internal/aws
package for sharing common aws specific logic. There is no official ECS metada client (and struct definitions). I think we should merge into the common logic to a package likeinternal/aws/ecsutil
Describe alternatives you've considered
It's possible to import resource detector processor in other components but it's kind of strange and makes the dependency more complex.
Additional context
N/A
The text was updated successfully, but these errors were encountered: