ext: ecsobserver Move ecsmock to internal

It should get moved into internal/aws in the future. Keep it under
extension package for now

extension/observer/ecsobserver/fetcher.go

@@ -24,19 +24,19 @@ import (
 	"go.uber.org/zap"
 )
 
-// ecsClient includes API required by TaskFetcher.
+// ecsClient includes API required by taskFetcher.
 type ecsClient interface {
 	ListTasksWithContext(ctx context.Context, input *ecs.ListTasksInput, opts ...request.Option) (*ecs.ListTasksOutput, error)
 	DescribeTasksWithContext(ctx context.Context, input *ecs.DescribeTasksInput, opts ...request.Option) (*ecs.DescribeTasksOutput, error)
 }
 
-type TaskFetcher struct {
+type taskFetcher struct {
 	logger  *zap.Logger
 	ecs     ecsClient
 	cluster string
 }
 
-type TaskFetcherOptions struct {
+type taskFetcherOptions struct {
 	Logger  *zap.Logger
 	Cluster string
 	Region  string
@@ -45,8 +45,8 @@ type TaskFetcherOptions struct {
 	ecsOverride ecsClient
 }
 
-func NewTaskFetcher(opts TaskFetcherOptions) (*TaskFetcher, error) {
-	fetcher := TaskFetcher{
+func newTaskFetcher(opts taskFetcherOptions) (*taskFetcher, error) {
+	fetcher := taskFetcher{
 		logger:  opts.Logger,
 		ecs:     opts.ecsOverride,
 		cluster: opts.Cluster,
@@ -55,12 +55,12 @@ func NewTaskFetcher(opts TaskFetcherOptions) (*TaskFetcher, error) {
 	if fetcher.ecs != nil {
 		return &fetcher, nil
 	}
-	panic("actual aws init logic not implemented")
+	return nil, fmt.Errorf("actual aws init logic not implemented")
 }
 
 // GetAllTasks get arns of all running tasks and describe those tasks.
 // There is no API to list task detail without arn so we need to call two APIs.
-func (f *TaskFetcher) GetAllTasks(ctx context.Context) ([]*ecs.Task, error) {
+func (f *taskFetcher) GetAllTasks(ctx context.Context) ([]*ecs.Task, error) {
 	svc := f.ecs
 	cluster := aws.String(f.cluster)
 	req := ecs.ListTasksInput{Cluster: cluster}

extension/observer/ecsobserver/fetcher_test.go

@@ -22,12 +22,12 @@ import (
 	"github.com/stretchr/testify/require"
 	"go.uber.org/zap"
 
-	"github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer/ecsobserver/ecsmock"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer/ecsobserver/internal/ecsmock"
 )
 
 func TestFetcher_GetAllTasks(t *testing.T) {
 	c := ecsmock.NewCluster()
-	f, err := NewTaskFetcher(TaskFetcherOptions{
+	f, err := newTaskFetcher(taskFetcherOptions{
 		Logger:      zap.NewExample(),
 		Cluster:     "not used",
 		Region:      "not used",

extension/observer/ecsobserver/task.go

@@ -23,7 +23,7 @@ import (
 )
 
 // Task contains both raw task info and its definition.
-// It is generated from TaskFetcher.
+// It is generated from taskFetcher.
 type Task struct {
 	Task       *ecs.Task
 	Definition *ecs.TaskDefinition