[Crypto] merge master to BLST feature branch #4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexander Hentschel <alex.hentschel@axiomzen.co>
4149: [Consensus] Service events processing order r=durkmurder a=durkmurder https://github.com/dapperlabs/flow-go/issues/6502 ### Context This PR changes how service events are processed. Previously service events were processed when observing QC for a block which seals service event. This was needed since follower couldn't determine payload validity even though participant could do it. In our current implementation follower accepts only certified blocks, meaning he has same safety guarantees as participant with respect to payload validity. We are changing service events to be processed directly in a block which seals them, not in next child. As part of this PR: - changed implementation - updated tests(badger, mutator, epochs) - updated epoch builder to include less blocks, updated tests P.S in many tests we had incorrectly built payload, for instance block contains a result and seal for same block, which is not supported. To be 100% honest, we still have many places where we don't enforce gap of 1 block between incorporated result and seal, but that can be refactored in separate PR(if needed). Please carefully check if I have correctly modified tests. Co-authored-by: Yurii Oleksyshyn <yuraolex@gmail.com> Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
4118: [Follower] Skipping proposals too far ahead of locally finalized view r=durkmurder a=durkmurder ### Context This PR removes `compliance.Config` from `follower.Core` and moves it to `follower.Engine` which uses `SkipNewProposalsThreshold` to drop proposals that are too far ahead in future. Co-authored-by: Yurii Oleksyshyn <yuraolex@gmail.com>
4126: Add an extra parameter for runtime config in `NewCustomReusableCadenceRuntimePool` constructor r=janezpodhostnik a=m-Peter
Prior to this change, an empty `runtime.Config{}` was used and there was no way to set a custom config.
A similar improvement was done in this PR #3768
Co-authored-by: Ardit Marku <markoupetr@gmail.com>
4093: Check reference at snapshot creation r=jordanschalm a=jordanschalm This PR extends #4086, adding checks to snapshot creation to differentiate between exceptions and unknown blocks in BlockSignerDecoder. - Updates `protocol.Snapshot` to guarantee that `ErrUnknownSnapshotReference` is returned in all cases where a snapshot's reference is unknown - Add existence checking methods to `storage/common`, `storage.Cache` - Updates BlockSignerDecoder to differentiate between errors from an unknown input block and exception - Misc: marks all unexpected errors in `storage/common` as exceptions - Misc: update `flow-emu` version to include onflow/flow-emulator#280 (avoid changes to `Headers` being breaking) Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
This test does not actually test the computer. The account status was populate into the view during account creation, before the block is executed.
4150: Remove delta view usage in fvm/ tests r=pattyshack a=pattyshack 4160: Remove bad test r=pattyshack a=pattyshack This test does not actually test the computer. The account status was populate into the view during account creation, before the block is executed. Co-authored-by: Patrick Lee <patrick.lee@dapperlabs.com>
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
…uctor • added unit tests for optional constructor arguments for PaceMaker
…o alex/use_qc_of_uncertified_block_optimization
f7926d5 to
2a851b5
Compare
… from verif vector
1b8002a to
7cd7c41
Compare
…th BLST's vec_zero
7cd7c41 to
bbd3c74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
G2membership check to pass testsE2set to infinity and compare to infinityflow_crypto_cgo_initfunction to check if BLST should be compiled without ADX, and catch the SIGILL signal with an appropriate message.vec_zero(the function accepts the length of the buffer to zero in bytes, but only works for multiple-of-8 lengths!). This results in a bug inE2scalar multiplications with a small exponent.