Port #4063 to master #4086
Merged
Port #4063 to master #4086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4086 +/- ##
==========================================
+ Coverage 53.45% 53.90% +0.44%
==========================================
Files 832 621 -211
Lines 77809 55458 -22351
==========================================
- Hits 41596 29892 -11704
+ Misses 32883 23180 -9703
+ Partials 3330 2386 -944
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 223 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peterargue
approved these changes
Mar 23, 2023
| @@ -83,11 +84,12 @@ func (s *blockSignerDecoderSuite) Test_UnexpectedCommitteeException() { | |||
| // It should propagate the sentinel error model.ErrViewForUnknownEpoch from Committee. | |||
| func (s *blockSignerDecoderSuite) Test_UnknownEpoch() { | |||
There was a problem hiding this comment.
can you add a couple more tests to cover the 3 error cases:
- ParentView's epoch is not in cache, but block exists
- IdentitiesByEpoch returns non-sentinel
- IdentitiesByBlock returns an error
There was a problem hiding this comment.
I've added these in a follow-up PR: #4093
Your comment made me realize that the implementation didn't differentiate between storage exceptions and unknown input blocks.
AlexHentschel
approved these changes
Mar 24, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Apr 4, 2023
4093: Check reference at snapshot creation r=jordanschalm a=jordanschalm This PR extends #4086, adding checks to snapshot creation to differentiate between exceptions and unknown blocks in BlockSignerDecoder. - Updates `protocol.Snapshot` to guarantee that `ErrUnknownSnapshotReference` is returned in all cases where a snapshot's reference is unknown - Add existence checking methods to `storage/common`, `storage.Cache` - Updates BlockSignerDecoder to differentiate between errors from an unknown input block and exception - Misc: marks all unexpected errors in `storage/common` as exceptions - Misc: update `flow-emu` version to include onflow/flow-emulator#280 (avoid changes to `Headers` being breaking) 4140: Storage layer test refactor r=janezpodhostnik a=janezpodhostnik Extracting pieces from #3736 so its easier to digest and merge. Co-authored-by: Jordan Schalm <jordan@dapperlabs.com> Co-authored-by: Janez Podhostnik <janez.podhostnik@gmail.com>
bors bot
added a commit
that referenced
this pull request
Apr 4, 2023
4093: Check reference at snapshot creation r=jordanschalm a=jordanschalm This PR extends #4086, adding checks to snapshot creation to differentiate between exceptions and unknown blocks in BlockSignerDecoder. - Updates `protocol.Snapshot` to guarantee that `ErrUnknownSnapshotReference` is returned in all cases where a snapshot's reference is unknown - Add existence checking methods to `storage/common`, `storage.Cache` - Updates BlockSignerDecoder to differentiate between errors from an unknown input block and exception - Misc: marks all unexpected errors in `storage/common` as exceptions - Misc: update `flow-emu` version to include onflow/flow-emulator#280 (avoid changes to `Headers` being breaking) Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
bors bot
added a commit
that referenced
this pull request
Apr 5, 2023
4093: Check reference at snapshot creation r=jordanschalm a=jordanschalm This PR extends #4086, adding checks to snapshot creation to differentiate between exceptions and unknown blocks in BlockSignerDecoder. - Updates `protocol.Snapshot` to guarantee that `ErrUnknownSnapshotReference` is returned in all cases where a snapshot's reference is unknown - Add existence checking methods to `storage/common`, `storage.Cache` - Updates BlockSignerDecoder to differentiate between errors from an unknown input block and exception - Misc: marks all unexpected errors in `storage/common` as exceptions - Misc: update `flow-emu` version to include onflow/flow-emulator#280 (avoid changes to `Headers` being breaking) Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DecodeSignerIDs#4063 tomaster