Ensure the same runtime config is used #3768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattyshack
approved these changes
Jan 4, 2023
Codecov Report
@@ Coverage Diff @@
## master #3768 +/- ##
=======================================
Coverage 55.36% 55.37%
=======================================
Files 768 768
Lines 70191 70194 +3
=======================================
+ Hits 38861 38868 +7
+ Misses 28148 28145 -3
+ Partials 3182 3181 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 8ff3253 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
janezpodhostnik
approved these changes
Jan 4, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Apr 5, 2023
4126: Add an extra parameter for runtime config in `NewCustomReusableCadenceRuntimePool` constructor r=janezpodhostnik a=m-Peter
Prior to this change, an empty `runtime.Config{}` was used and there was no way to set a custom config.
A similar improvement was done in this PR #3768
Co-authored-by: Ardit Marku <markoupetr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various places create Cadence
runtime.Configs, e.g.NewReusableCadenceRuntimecreates an empty one, even when the runtime was potentially created using a different one (e.g. byReusableCadenceRuntimePool.newCustomRuntime).Propagate the runtime configuration, so it is consistently the same everywhere in
ReusableCadenceRuntimePoolandReusableCadenceRuntime.