Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore benchstat on forks #4146

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Ignore benchstat on forks #4146

merged 1 commit into from
Apr 5, 2023

Conversation

janezpodhostnik
Copy link
Contributor

@janezpodhostnik janezpodhostnik commented Apr 3, 2023

I will open an issue to fix this properly. This is just to unblock #4126

Issue to fix this properly: #4147

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit ae79b52

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
ComputeBlock/16/cols/128/txes-24.27s ± 0%4.26s ± 0%~(p=1.000 n=1+1)
 
us/txdelta
ComputeBlock/16/cols/128/txes-22.09k ± 0%2.08k ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
ComputeBlock/16/cols/128/txes-21.21GB ± 0%1.19GB ± 0%~(p=1.000 n=1+1)
 
allocs/opdelta
ComputeBlock/16/cols/128/txes-217.1M ± 0%17.1M ± 0%~(p=1.000 n=1+1)
 

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Merging #4146 (2e9cb08) into master (ae79b52) will increase coverage by 2.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4146      +/-   ##
==========================================
+ Coverage   53.60%   56.57%   +2.96%     
==========================================
  Files         836      373     -463     
  Lines       78312    34405   -43907     
==========================================
- Hits        41981    19464   -22517     
+ Misses      32978    13304   -19674     
+ Partials     3353     1637    -1716     
Flag Coverage Δ
unittests 56.57% <ø> (+2.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 466 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@janezpodhostnik
Copy link
Contributor Author

bors merge

@bors bors bot merged commit dcb617f into master Apr 5, 2023
@bors bors bot deleted the janez/benchstat-on-fork-prs branch April 5, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants