Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for trashbin #3905

Merged
merged 2 commits into from
Apr 12, 2017
Merged

Add integration test for trashbin #3905

merged 2 commits into from
Apr 12, 2017

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews downstream labels Mar 17, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Mar 17, 2017
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @LukasReschke and @rullzer to be potential reviewers.

And user "user1" favorites element "/shared/shared_file.txt"
When User "user1" moved file "/shared/shared_file.txt" to "/taken_out.txt"
Then user "user1" in folder "/" should have favorited the following elements
| /taken_out.txt |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests seems to fail. The path is prefixed with /remote.php/webdav. @icewind1991 @rullzer Is this correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is the correct webdav path

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rullzer I adjusted the path in the tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is forbidden. I will move this to a separate PR to maybe debug this.

@ChristophWurst
Copy link
Member

--- Failed scenarios:
/drone/src/github.com/nextcloud/server/build/integration/features/favorites.feature:137

@MorrisJobke
Copy link
Member Author

Aaah ... now it says:

/remote.php/webdav/remote.php/webdav/taken_out.txt is not in report answer

before prepending the /remote.php/webdav it said:

/taken_out.txt is not in report answer

🙈

@MorrisJobke
Copy link
Member Author

Let's see if it works now

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this!

@MorrisJobke
Copy link
Member Author

I will also rebase to get #4302 resolved.

Vincent Petry and others added 2 commits April 11, 2017 14:59
Add test for basic deletion.
Add test when deleting from shared folder as recipient.
Add test to check that metadata stays when moving out of shared folder
as recipient.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member Author

👍 from me as well for this

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 11, 2017
@nickvergessen nickvergessen merged commit af42ca2 into master Apr 12, 2017
@nickvergessen nickvergessen deleted the downstream-27069 branch April 12, 2017 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants