-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for trashbin #3905
Conversation
MorrisJobke
commented
Mar 17, 2017
- downstream of Add integration test for trashbin owncloud/core#27069
- redo of Add integration test for trashbin #3893
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @LukasReschke and @rullzer to be potential reviewers. |
And user "user1" favorites element "/shared/shared_file.txt" | ||
When User "user1" moved file "/shared/shared_file.txt" to "/taken_out.txt" | ||
Then user "user1" in folder "/" should have favorited the following elements | ||
| /taken_out.txt | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests seems to fail. The path is prefixed with /remote.php/webdav
. @icewind1991 @rullzer Is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that is the correct webdav path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rullzer I adjusted the path in the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is forbidden. I will move this to a separate PR to maybe debug this.
|
Aaah ... now it says:
before prepending the
🙈 |
3f1be48
to
5779bde
Compare
Let's see if it works now |
5779bde
to
b3531f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets do this!
I will also rebase to get #4302 resolved. |
Add test for basic deletion. Add test when deleting from shared folder as recipient. Add test to check that metadata stays when moving out of shared folder as recipient. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
b3531f9
to
749046a
Compare
👍 from me as well for this |